no-issue: add adjustment return tax and response field parsing - #13
Merged
reshmabidikar merged 1 commit intoSep 21, 2026
Merged
Conversation
Contributor
Author
|
Pushed an additional commit onto this branch with the Dependabot dependency fixes (Jackson annotations/core/databind aligned to 2.22.x, wiremock 3.0.1, surefire 3.6.0, GHA checkout/setup-java/codeql bumps). That supersedes #14 and the open Dependabot PRs #3–#6 / #8–#10. #7 (oss-parent 0.147) stays out — Jakarta/JDK 21 migration, not a drop-in bump. |
JeffTax
force-pushed
the
chore/no-ref/sync-adj-external-id
branch
from
September 18, 2026 15:31
e3f5d69 to
5e0fec8
Compare
Port invoice-tax fixes: ITEM_ADJ/REPAIR_ADJ return estimates, EXTERNAL_CHARGE product identity, alternate tax-line field names, and skip empty sales POSTs. Bump Jackson annotations/core/databind together and apply the other green Dependabot upgrades so CI stays green. Leave oss-parent at 0.146.x.
JeffTax
force-pushed
the
chore/no-ref/sync-adj-external-id
branch
from
September 18, 2026 20:34
667edbb to
d5e6d35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainITEM_ADJ/REPAIR_ADJ(negative TAX linked to the adj item;{invoiceId}:adj-returndocument id)EXTERNAL_CHARGEproduct external id for plan-less external chargesline_external_id/rate_percentage(with fallback toexternal_id/rate) on tax line responsesTests
JAVA_HOME=…/openjdk@11 mvn -B -ntp test— 62 tests, 0 failuresTestInvoiceRequestMapperandTestInvoiceTaxIdempotency(return estimate, external charge identity, adj-only skip)