Conversation
The docs said a silence created from an alert group had a Scope of "Group-bound", which promised a restriction that does not exist. The group binding only controls when the silence ends: on resolve, the silence's expiry is moved to that moment so it lifts early. Matching never reads it, so the silence mutes every alert in the workspace whose labels match its matchers, group member or not. This caused a support question, so it is now stated directly in the anatomy table, in a caution on the group flow, and on the alert-groups page. The Scope column is now Ends, with At expiry and When the group resolves. "From an Alert Group" also claimed the group's labels were pre-filled as matchers. That read alarm_groups.labels, which holds only the distinctive k=v a correlated group matched on and is empty for most groups, so nothing pre-filled. Matchers are now derived server-side from the routing rule's group_by keys, the value every live member shares, then alarm_id. A group whose alerts share no label pre-fills nothing and offers its alerts' labels as chips with per-label coverage. Adding every offered chip does not scope the silence to the group, and the page now says why with the measured numbers: a folder label on 10 of 17 alerts takes the match down to 10 and leaves 7 notifying, while two multi-valued keys accept their cartesian product. The "Alerts this silence will mute" preview is the honest check. Also documents the Alerts muted column and its row expansion, and the Silenced badge now linking to whatever is muting the alert. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Adds alerts/export-and-import.mdx for moving rules between workspaces: Export as JSON on a rule row, Export alerts as JSON on a folder header, and Import JSON on the Alerts list. Wired into the create-alerts row actions, the folders kebab list and Related, and the alerts index cards. Covers what does not survive the move, which is not visible from the UI: the folder, the Dashboard and Panel links, and Smart Alerts ownership, since stripping the internal __…__ annotations drops __km_source__ and the detector stops managing the copy. Folder inheritance does survive, so an imported rule runs on system defaults until it is put in a folder. AWS is the one thing import has to rebind. An account connects to KloudMate once, so the exported account id never exists in the destination: one account binds automatically, several needs a choice, none imports the rules paused. Region, namespace and dimensions are copied verbatim and need review. Also covers the retry path for a partial import and the fact that nothing dedupes, so importing the same JSON twice duplicates every rule. Source is kloudmate-frontend a301266f, which is frontend-only and already in master, so nothing here is release-gated. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Two rules that had to be given in review rather than read off the file.
"Trust the reader" covers three habits: describing what a control displays
("the button shows the number it will create"), announcing a list before
showing it ("it leaves out everything that can't survive the move", above a
table of exactly that), and justifying what the reader can infer ("the rules
import paused, so they don't fire against an account they can't read"). The
test is whether deleting the sentence changes what a competent reader does.
The sentence-shape section gains the maintainer's own rewrite of an opening
paragraph as the reference: name the capability outright, keep full
determiners, use the verb that names the reader's goal, and drop vague
pronoun tails. Trimming fluff and writing complete sentences pull in opposite
directions without this, which is why the first pass over-corrected into
clipped prose.
Also notes that product jargon in context is fine; it is the ornamental
register around it that reads as AI.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.