feat: function version migrations#664
Merged
Merged
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## main #664 +/- ##
==========================================
+ Coverage 37.93% 38.03% +0.10%
==========================================
Files 41 42 +1
Lines 3872 3917 +45
==========================================
+ Hits 1469 1490 +21
- Misses 2212 2225 +13
- Partials 191 202 +11
Continue to review full report at Codecov.
|
lkingland
force-pushed
the
lkingland/migrations
branch
2 times, most recently
from
November 17, 2021 06:02
b7b7600 to
72348b1
Compare
lance
reviewed
Nov 17, 2021
lance
left a comment
Contributor
There was a problem hiding this comment.
This is a nice addition. Thanks!
/lgtm
lkingland
force-pushed
the
lkingland/migrations
branch
from
November 18, 2021 02:49
72348b1 to
bf648bb
Compare
lkingland
force-pushed
the
lkingland/migrations
branch
2 times, most recently
from
November 18, 2021 03:39
ccead95 to
46d008e
Compare
Member
Author
|
Tests have (thankfully, though a bit begrudgingly) uncovered a logical inconsistency in Function instantiation. Marking this as draft until I can get it sorted out. |
lkingland
marked this pull request as draft
November 18, 2021 04:55
lkingland
force-pushed
the
lkingland/migrations
branch
2 times, most recently
from
November 18, 2021 08:36
0b22d7c to
29bd550
Compare
lkingland
force-pushed
the
lkingland/migrations
branch
from
November 24, 2021 01:55
29bd550 to
24c9222
Compare
* adds new test confirming name is properly defaulted in new Functions.
lkingland
marked this pull request as ready for review
November 24, 2021 03:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces the concept of Function versions and associated migrations. Includes a single migration which initializes version and creation fields for Functions <=v0.19.0.
PR #641 takes advantage of function creation timestamp to determine if a Function has been initialized. Functions created prior to this stamp being introduced (forthcoming v0.20.0) should have their Creation stamp initialized to maintain backwards compatibility.
Migrations are applied when a Function is instantiated (read from func.yaml) in the order in which they are registered.
Currently the only migration is that which takes a Function from unversioned to versioned, and initialized a creation timestamp. The version written to func.yaml is the latest migration applied, indicating migrations can be skipped on subsequent loads until a new migration is added to the codebase.
Fixes #674
/kind enhancement