feat: make templates consistent across runtimes#948
Conversation
Fixes: knative#572 Signed-off-by: Lance Ball <lball@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## main #948 +/- ##
==========================================
+ Coverage 43.85% 45.83% +1.98%
==========================================
Files 55 57 +2
Lines 5163 7442 +2279
==========================================
+ Hits 2264 3411 +1147
- Misses 2576 3703 +1127
- Partials 323 328 +5
Continue to review full report at Codecov.
|
|
/lgtm |
zroubalik
left a comment
There was a problem hiding this comment.
Looking good, just a small nit. I'd add blank lines around the comment, to make it more prominent and easily recognizable for users when the open the source code for the first time.
Signed-off-by: Lance Ball <lball@redhat.com>
|
@lance there are style issues, and the embedded templates contains some |
Signed-off-by: Lance Ball <lball@redhat.com>
|
There is trailing white space in |
Signed-off-by: Lance Ball <lball@redhat.com>
|
/lgtm as well! |
|
/unhold |
|
/lgtm |
Changes
/kind enhancement
Fixes: #572
Release Note