Skip to content

feat: make templates consistent across runtimes#948

Merged
knative-prow[bot] merged 4 commits into
knative:mainfrom
lance:lance/572-consistent-templates
Apr 8, 2022
Merged

feat: make templates consistent across runtimes#948
knative-prow[bot] merged 4 commits into
knative:mainfrom
lance:lance/572-consistent-templates

Conversation

@lance

@lance lance commented Apr 6, 2022

Copy link
Copy Markdown
Contributor

Changes

/kind enhancement

Fixes: #572

Release Note

Aligns all templates to a common standard behavior and comments

Fixes: knative#572

Signed-off-by: Lance Ball <lball@redhat.com>
@knative-prow knative-prow Bot added kind/enhancement Feature additions or improvements to existing size/XXL 🤖 PR changes 1000+ lines, ignoring generated files. labels Apr 6, 2022
@knative-prow

knative-prow Bot commented Apr 6, 2022

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved 🤖 PR has been approved by an approver from all required OWNERS files. label Apr 6, 2022
@codecov

codecov Bot commented Apr 6, 2022

Copy link
Copy Markdown

Codecov Report

Merging #948 (677314e) into main (739cded) will increase coverage by 1.98%.
The diff coverage is 29.13%.

@@            Coverage Diff             @@
##             main     #948      +/-   ##
==========================================
+ Coverage   43.85%   45.83%   +1.98%     
==========================================
  Files          55       57       +2     
  Lines        5163     7442    +2279     
==========================================
+ Hits         2264     3411    +1147     
- Misses       2576     3703    +1127     
- Partials      323      328       +5     
Impacted Files Coverage Δ
cmd/completion_util.go 0.00% <0.00%> (ø)
cmd/invoke.go 34.81% <0.00%> (-0.97%) ⬇️
docker/docker_client.go 82.52% <ø> (+0.57%) ⬆️
k8s/logs.go 0.00% <0.00%> (ø)
k8s/secrets.go 13.54% <0.00%> (-0.75%) ⬇️
s2i/builder.go 32.69% <32.69%> (ø)
client.go 61.94% <50.00%> (+2.01%) ⬆️
invoke.go 52.99% <61.53%> (+2.99%) ⬆️
cmd/build.go 60.49% <70.83%> (+0.86%) ⬆️
cmd/root.go 72.28% <100.00%> (+1.66%) ⬆️
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ee9fa1...677314e. Read the comment docs.

@matejvasek

Copy link
Copy Markdown
Contributor

/lgtm
/hold for tests

@knative-prow knative-prow Bot added the do-not-merge/hold 🤖 PR should not merge because someone has issued a /hold command. label Apr 6, 2022
@knative-prow knative-prow Bot added the lgtm 🤖 PR is ready to be merged. label Apr 6, 2022

@zroubalik zroubalik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a small nit. I'd add blank lines around the comment, to make it more prominent and easily recognizable for users when the open the source code for the first time.

Comment thread templates/python/cloudevents/func.py
Comment thread templates/quarkus/cloudevents/src/main/java/functions/Function.java
Comment thread templates/quarkus/http/src/main/java/functions/Function.java
Signed-off-by: Lance Ball <lball@redhat.com>
@knative-prow knative-prow Bot removed the lgtm 🤖 PR is ready to be merged. label Apr 7, 2022
@matejvasek

Copy link
Copy Markdown
Contributor

@lance there are style issues, and the embedded templates contains some target/* files that shouldn't be there.

Signed-off-by: Lance Ball <lball@redhat.com>
@matejvasek

Copy link
Copy Markdown
Contributor

There is trailing white space in templates/python/cloudevents/func.py:11:.

Signed-off-by: Lance Ball <lball@redhat.com>
@lkingland

Copy link
Copy Markdown
Member

/lgtm as well!

@matejvasek

Copy link
Copy Markdown
Contributor

/unhold

@knative-prow knative-prow Bot removed the do-not-merge/hold 🤖 PR should not merge because someone has issued a /hold command. label Apr 8, 2022
@matejvasek

Copy link
Copy Markdown
Contributor

/lgtm

@knative-prow knative-prow Bot added the lgtm 🤖 PR is ready to be merged. label Apr 8, 2022
@knative-prow
knative-prow Bot merged commit 13d4222 into knative:main Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved 🤖 PR has been approved by an approver from all required OWNERS files. kind/enhancement Feature additions or improvements to existing lgtm 🤖 PR is ready to be merged. size/XXL 🤖 PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide a consistent developer experience for all function templates

4 participants