Read ReplaceWith's new items before clearing the collection - #133
Merged
Merged
Conversation
ReplaceWith cleared the collection and then enumerated newItems, so a lazy query over the collection (items.Where(...)) or the collection itself yielded nothing and the collection ended up empty. Snapshot newItems into an array before clearing. Fixes #132 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012Hhb8knddbu4LRSs2uu9jR
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #132
Problem
CollectionExtensions.ReplaceWithcalledClear()before it enumeratednewItems. WhennewItemswas the collection itself, or a lazy query over it, the enumeration happened after the clear and yielded nothing. The collection was silently emptied:list.ReplaceWith(list.Where(x => x > 2))gave[]where[3, 4]was expected.list.ReplaceWith(list)gave[]where[1, 2, 3]was expected.Fix
ReplaceWithnow copiesnewItemsinto an array first, then clears the collection and adds from the array. The argument validation is unchanged.Tests
New tests in
CollectionExtensionsTests:ReplaceWithLazyQueryOverSameCollectionKeepsMatchingItemsReplaceWithSameCollectionKeepsItemsWith the fix reverted, both fail. With it, the full suite passes (136/136). The library also builds cleanly in Release for all of its target frameworks.
This PR is independent of #131; both branch from
main.🤖 Generated with Claude Code
https://claude.ai/code/session_012Hhb8knddbu4LRSs2uu9jR
Generated by Claude Code