fix(mcp): return controlled errors for Milvus search failures - #252
Open
sanjayy0612 wants to merge 1 commit into
Open
sanjayy0612 wants to merge 1 commit into
sanjayy0612 wants to merge 1 commit into
Conversation
Signed-off-by: sanjayy0612 <sanjayelango06@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #251
Problem
The shared MCP search helper handled failures while loading a Milvus collection and generating an embedding, but exceptions from the actual vector search escaped the tool boundary. A transient Milvus timeout could therefore abort documentation, GitHub issue, and code search invocations.
Root cause
_search_collection()calledclient.search()outside the existingRuntimeErrornormalization used by the public MCP tools.Solution
Wrap the Milvus search operation and raise a contextual
RuntimeError. Existing tool handlers now return a controlledSearch failed: ...response. A regression test simulates a Milvus timeout and verifies that behavior.Testing
pytest tests/test_mcp_server.py: 64 passedpytest: 168 passed, 6 skippedruff check docs-agent-mcp/mcp-server testsruff format --check docs-agent-mcp/mcp-server testsgit diff --check