Skip to content

chore: remove metrics logger - #31

Merged
dongjiang1989 merged 9 commits into
mainfrom
fix-metrics-logger
Dec 13, 2024
Merged

dongjiang1989 merged 9 commits into
mainfrom
fix-metrics-logger

Conversation

@dongjiang1989

Copy link
Copy Markdown
Member

What type of PR is this?

/kind feature

  • Unittest
  • Coverage 80%+
  • Build Success

What this PR does / why we need it:

  1. remove metrics logger
  2. update package version

Signed-off-by: dongjiang <dongjiang1989@126.com>
@pull-request-size pull-request-size Bot added the size/L size/L label Dec 13, 2024
@the-label-bot

the-label-bot Bot commented Dec 13, 2024

Copy link
Copy Markdown

The Label Bot has predicted the following:

Category Value Confidence Applied Label

@codacy-production

codacy-production Bot commented Dec 13, 2024

Copy link
Copy Markdown

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (770af3d) 6971 6198 88.91%
Head commit (32e6064) 6969 (-2) 6196 (-2) 88.91% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#31) 13 13 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@github-actions
github-actions Bot requested a review from imlense December 13, 2024 03:57
@github-advanced-security

Copy link
Copy Markdown

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Signed-off-by: dongjiang <dongjiang1989@126.com>
Signed-off-by: dongjiang <dongjiang1989@126.com>
Signed-off-by: dongjiang <dongjiang1989@126.com>
Signed-off-by: dongjiang <dongjiang1989@126.com>
Signed-off-by: dongjiang <dongjiang1989@126.com>
@codecov

codecov Bot commented Dec 13, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.68%. Comparing base (3b913a3) to head (9951071).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
- Coverage   86.32%   85.68%   -0.64%     
==========================================
  Files          97       99       +2     
  Lines        6360     6474     +114     
==========================================
+ Hits         5490     5547      +57     
- Misses        697      752      +55     
- Partials      173      175       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: dongjiang <dongjiang1989@126.com>
Signed-off-by: dongjiang <dongjiang1989@126.com>
Signed-off-by: dongjiang <dongjiang1989@126.com>
@sonarqubecloud

Copy link
Copy Markdown

@dongjiang1989
dongjiang1989 merged commit ed01077 into main Dec 13, 2024
@dongjiang1989
dongjiang1989 deleted the fix-metrics-logger branch February 14, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants