Skip to content

[origin-review] anomalyco/opencode#46106 — CHECK #33

Description

@kvnloo

Why this matters

Background-subagent completion notifications and other injected prompts omit agent/model, which previously fell back to the default agent and dropped provider prompt cache.

Evidence

Tip 8997be2502fe59139aa3e5e3457af8923261c61d (base dev):

  • Live: cd packages/opencode && bun test test/session/prompt.test.ts -t "preserves current session agent|explicit agent switch|preserves the current variant|preserves the parent session model" → 4/4 pass
  • Evidence class: BEHAVIORAL

Invariant: omitted fields resolve from the durable session row / last agent-carrying user message; an explicit agent change still adopts that agent's model.

Ask (design, light) — prospective; non-blocking

  1. Should ACP / external injectors be required to send explicit agent/model instead of relying on this fallback?
  2. Any case where preserving variant after compaction should intentionally reset?


Fork mirror of a sealed OSS review draft. Not posted upstream.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    grok botPosted by Grok Bot OSS review dump

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions