[origin-review] anomalyco/opencode#50832 — CHECK

[kvnloo]

Why this matters

A single bad model field made diagnostics blame the whole provider block, so operators could not see which leaf was wrong.

Evidence

Tip 0771fafeb0d73018852e6f7cc870d4c881cea5ab (base v2):

• Leaf: packages/core/src/config/normalize.ts
• Live: cd packages/core && bun test test/config/normalization.test.ts → 28/28 pass
• Evidence class: BEHAVIORAL

Invariant: invalid leaf → localized diagnostic path; siblings retained when possible.

Ask (design, light) — prospective; non-blocking

1. Should every config recovery path share one “diagnose the invalid leaf, keep siblings” contract?
2. For never-again: are whole-object diagnostics banned when a leaf schema fails?

---

---

Fork mirror of a sealed OSS review draft. Not posted upstream.

• origin: fix(core): localize config normalization diagnostics to the failing field anomalyco/opencode#50832
• tip: 0771fafeb0d73018852e6f7cc870d4c881cea5ab
• evidence: BEHAVIORAL — tip-native bun test test/config/normalization.test.ts → 28/28 pass (incl. localizes the field that invalidates a native provider model)
• pack: 05 draft 003
• dedupe_key: anomalyco/opencode#50832
• github_writes_origin: 0

[kvnloo]

HOLD — normalization tests are green, but operator-facing recovery is under-proven

The 28/28 normalization suite is useful. The maintainer decision hinges on whether one bad leaf now produces a localized diagnostic without discarding valid siblings in the actual config load path.

Upgrade:

1. load a provider config with one invalid nested model field plus at least one valid sibling model/field;
2. exercise the real config normalization/load boundary;
3. assert the diagnostic path points to the failing leaf, not the whole provider;
4. assert unaffected siblings remain available when the existing recovery policy allows it;
5. negative control: restore whole-object diagnostic behavior and show the path/sibling assertion fails;
6. confirm overlap with fix(config): default omitted model tools capability anomalyco/opencode#50702/fix(schema): default omitted capability tools for custom providers anomalyco/opencode#49940 does not make this diagnostic-only PR redundant.

Promote only the diagnostic-localization invariant; do not imply this PR fixes the underlying capability-schema bugs.

[kvnloo]

done — config load-boundary diagnostic localization

Pin / drift

	SHA
Work-order pin (still origin anomalyco#50832 head)	0771fafeb0d73018852e6f7cc870d4c881cea5ab
Strengthen tip	cc954ff554c3308efc92f8dd36bb3d3941d86812

Drift: fork tip dev lacks packages/core/src/config/normalize.ts; evidence on pin lineage.

Upgrade

1. ConfigNormalize.normalize with invalid nested model leaf + valid sibling provider
2. Diagnostic path = leaf (providers.broken.models.chat.capabilities.tools)
3. Sibling healthy retained
4. Negative: whole-object path fails leaf/sibling assertions
5. Overlap: does not own fix(schema): default omitted capability tools for custom providers anomalyco/opencode#49940/fix(config): default omitted model tools capability anomalyco/opencode#50702 tools-default — localization only

Fail → pass

cd packages/core && bun test test/config/normalization.test.ts
# 30 pass / 0 fail

Land

• Branch: factory/config-diag-localize-strengthen-50832
• Fork PR: https://github.com/kvnloo/opencode/pull/$(gh pr list --repo kvnloo/opencode --head factory/config-diag-localize-strengthen-50832 --json number -q '.[0].number')
• Evidence: /workspace/batch-a/evidence/opencode-47-config-diag.log
• Notes: /workspace/batch-a/opencode-47.md

github_writes_origin=0

[kvnloo]

CHECK sweep disposition remains REPAIR_CANDIDATE.

The 28/28 normalization tests do not fully prove the operator-facing recovery contract.

Acceptance through the real config-load path:

1. one invalid nested model leaf + valid sibling values;
2. diagnostic points to the exact failing leaf;
3. unaffected siblings survive when policy permits;
4. negative control restores whole-object diagnostic/drop behavior;
5. keep this diagnostic-only PR distinct from the schema/default decision in fix(config): default omitted model tools capability anomalyco/opencode#50702/fix(schema): default omitted capability tools for custom providers anomalyco/opencode#49940.

The v2 issue-link bot behavior is a workflow artifact, not the technical blocker.