Skip to content

tip: ignore non-object SSE keep-alive frames (#50508) - #155

Open
kvnloo wants to merge 1 commit into
devfrom
tip/50508-sse-keepalive-frames
Open

kvnloo wants to merge 1 commit into
devfrom
tip/50508-sse-keepalive-frames

Conversation

@kvnloo

@kvnloo kvnloo commented Sep 27, 2026

Copy link
Copy Markdown
Owner

Tip leaf (fork-only) — CLEAN

Maps to work-order issue #154. Upstream origin anomalyco#50508 (not touched / not promoted).

What: Drop empty/[DONE]/non-object JSON keep-alive SSE payloads so decodeChunk sees one object event per element (gateways that inject data: null).

Commit: 8f3d1170c470fa3893a2652075901b5a8c3fab53
Origin tip SHA: 7dd74c0601fd

Proof: fail→pass on openai-compatible-chat keep-alive filters (GREEN 2 / NEG 1 fail / RESTORE 2).

github_writes_origin: 0. Codex promote parked.

Drop empty/[DONE]/non-object JSON keep-alive SSE payloads so decodeChunk
sees one object event per element (gateways that inject data: null).

Origin tip: anomalyco#50508
Origin SHA: 7dd74c0
Fork-only tip leaf; github_writes_origin=0.
@kvnloo kvnloo added the grok bot Posted by Grok Bot OSS review dump label Sep 27, 2026
@github-actions

Copy link
Copy Markdown

Hey! Your PR title tip: ignore non-object SSE keep-alive frames (#50508) doesn't follow conventional commit format.

Please update it to start with one of:

  • feat: or feat(scope): new feature
  • fix: or fix(scope): bug fix
  • docs: or docs(scope): documentation changes
  • chore: or chore(scope): maintenance tasks
  • refactor: or refactor(scope): code refactoring
  • test: or test(scope): adding or updating tests

Where scope is the package name (e.g., app, desktop, opencode).

See CONTRIBUTING.md for details.

@github-actions

Copy link
Copy Markdown

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

  • PR description is missing required template sections. Please use the PR template.

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

kvnloo commented Sep 29, 2026

Copy link
Copy Markdown
Owner Author

READY_UPSTREAM

Rechecked before promotion:

Use local gh/Hermes to post the validation note upstream; the ChatGPT GitHub App gets 403 on anomalyco/opencode. Do not open a duplicate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

grok bot Posted by Grok Bot OSS review dump needs:title

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant