Skip to content

tip: terminate WS streams on error events (#50854) - #161

Open
kvnloo wants to merge 1 commit into
devfrom
tip/50854-terminate-ws-on-errors
Open

kvnloo wants to merge 1 commit into
devfrom
tip/50854-terminate-ws-on-errors

Conversation

@kvnloo

@kvnloo kvnloo commented Sep 27, 2026

Copy link
Copy Markdown
Owner

Tip leaf (fork-only) — CLEAN

Maps to work-order issue #160. Upstream origin anomalyco#50854 (not touched / not promoted).

What: Treat top-level error events as terminal so OpenAI Responses websocket streams stop on provider errors (e.g. rate_limit_exceeded).

Commit: 7104bb323d02caffc1e225318650bc6c4d3edd00
Origin tip SHA: 583811a7b456790262501f510d1e9d72194071cc

Proof: fail→pass on packages/llm/test/provider/openai-responses.test.ts filter terminates an OpenAI Responses stream on a top-level error event (GREEN 1 / NEG 1 fail / RESTORE 1).

github_writes_origin: 0. Codex promote parked.

@kvnloo kvnloo added the grok bot Posted by Grok Bot OSS review dump label Sep 27, 2026
@github-actions

Copy link
Copy Markdown

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

  • PR description is missing required template sections. Please use the PR template.

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

@github-actions

Copy link
Copy Markdown

Hey! Your PR title tip: terminate WS streams on error events (#50854) doesn't follow conventional commit format.

Please update it to start with one of:

  • feat: or feat(scope): new feature
  • fix: or fix(scope): bug fix
  • docs: or docs(scope): documentation changes
  • chore: or chore(scope): maintenance tasks
  • refactor: or refactor(scope): code refactoring
  • test: or test(scope): adding or updating tests

Where scope is the package name (e.g., app, desktop, opencode).

See CONTRIBUTING.md for details.

kvnloo commented Sep 29, 2026

Copy link
Copy Markdown
Owner Author

READY_UPSTREAM

Rechecked before promotion:

Use local gh/Hermes to post the validation note upstream; the ChatGPT GitHub App gets 403 on anomalyco/opencode. Do not open a duplicate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

grok bot Posted by Grok Bot OSS review dump needs:title

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants