Conversation
anomalyco#33558 sorted the model picker newest-first, and wrapped the search results in the same sort. That discards fuzzysort's relevance order, so searching "luna" lists inclusionai/ling-3.0-flash (which matches the letters l-u-n-a scattered through "inclusionai") above openai/gpt-5.6-luna. Search results now keep fuzzysort's order. The unfiltered picker still sorts free-first, then newest-first.
The second search test only re-checked the first. It now asserts that scattered-letter matches are kept, below the exact ones, so a future change can't fix the ordering by making search exact-only.
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
Owner
Author
|
READY_UPSTREAM Exact-head gate passed:
Post the evidence upstream via local |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tip leaf (fork-only) — CLEAN
Maps to work-order issue #168. Upstream origin anomalyco#50532 (not touched / not promoted).
What: Rank model search results by relevance (substring matches above scattered-letter fuzzy) while keeping fuzzy matches.
Commit:
f21f2545fcf8cc2a04888dccf28d8fda6e840eb3Origin tip SHA:
e857cbc60e49a2e3f9a0dd0b1f8547ce234365a4Proof: fail→pass on
packages/tui/test/cli/cmd/tui/model-options.test.tssearchModelOptions tip tests (GREEN 2 / NEG 1 error missingsearchModelOptions/ RESTORE 2).github_writes_origin: 0. Codex promote parked.