Conversation
V2-to-V1 normalization dropped any MCP server whose timeout was a plain number, because the compat Timeout schema only accepted the legacy {catalog, execution} struct. A numeric global mcp.timeout was worse: it was treated as a server entry and failed the whole config with ConfigInvalidError.
Accept PositiveInt alongside the struct, lower a numeric or {request} timeout to the V1 number, and treat a numeric global timeout as the global timeout.
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tip leaf (fork-only) — CLEAN
Maps to work-order issue #176. Upstream origin anomalyco#50911 (not touched / not promoted).
What: Retain numeric MCP server/global timeout entries when lowering V2 config to V1.
Commit:
c6e85dee142ee22b43dee0944db32c1949baa0b9Origin tip SHA:
c85065fb35a0ff4d6e77356a60c17989c4f89739Proof: fail→pass on tip MCP timeout tests (GREEN 4 / NEG 4 fail / RESTORE 4).
github_writes_origin: 0. Codex promote parked.