Conversation
This was referenced Sep 26, 2026
kvnloo
force-pushed
the
fix/app-utf8-server-credentials
branch
from
October 3, 2026 21:18
d757ba9 to
ccb9816
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refreshes the UTF-8 Basic-auth credential fix onto current
dev.authTokenFromCredentialsnow encodesusername:passwordas UTF-8 bytes before standard Base64. ASCII output stays unchanged; regression coverage includes Latin-1-range and multibyte credentials.Credit / provenance
This carries forward upstream anomalyco#46225 by @sdivyanshu90. Credit for the original diagnosis and implementation direction belongs to them. This downstream branch only refreshes that work onto the current tree and preserves focused regression coverage.
Current refresh
devon 2026-10-03packages/app/src/utils/server.tsandserver.test.tschangedVerification
The original upstream PR reported its focused app tests and typecheck green. Current upstream CI should revalidate this refreshed head before merge.
github_writes_origin=0— ready to promote when upstream write access is available.