Skip to content

fix(app): encode server credentials as UTF-8 (origin #46225) - #71

Open
kvnloo wants to merge 2 commits into
devfrom
fix/app-utf8-server-credentials
Open

kvnloo wants to merge 2 commits into
devfrom
fix/app-utf8-server-credentials

Conversation

@kvnloo

@kvnloo kvnloo commented Sep 26, 2026 •

Copy link
Copy Markdown
Owner

Summary

Refreshes the UTF-8 Basic-auth credential fix onto current dev.

authTokenFromCredentials now encodes username:password as UTF-8 bytes before standard Base64. ASCII output stays unchanged; regression coverage includes Latin-1-range and multibyte credentials.

Credit / provenance

This carries forward upstream anomalyco#46225 by @sdivyanshu90. Credit for the original diagnosis and implementation direction belongs to them. This downstream branch only refreshes that work onto the current tree and preserves focused regression coverage.

Current refresh

  • rebased cleanly onto current dev on 2026-10-03
  • 0 commits behind
  • only packages/app/src/utils/server.ts and server.test.ts changed
  • no unrelated dependency/lockfile changes

Verification

The original upstream PR reported its focused app tests and typecheck green. Current upstream CI should revalidate this refreshed head before merge.

github_writes_origin=0 — ready to promote when upstream write access is available.

@kvnloo
kvnloo force-pushed the fix/app-utf8-server-credentials branch from d757ba9 to ccb9816 Compare October 3, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant