Show each runtime's best result in hardware charts - #47
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
No result files to import. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Hardware charts currently choose one winner per model and quantization across all runtimes, so Cascadia disappears on the Arc Pro B70 page when another runtime is faster. Show the best result per model, quantization, and runtime instead, label each bar with its runtime, and remove the ten-bar cutoff so slower runtime winners remain visible.
Both the production and mock APIs use the same chart builder. The heading describes the new grouping. This changes hardware charts only; issue #44 concerns model leaderboard badge explanations and remains separate.
Checks
npm --prefix frontend run typecheckpasses (via production build)npm --prefix frontend run buildpassesnpm --prefix frontend run results:testpasses (22 tests)Build reports existing Vite configuration and bundle-size warnings. Browser visual verification was not performed.