feat: add 2.1 read path - #2968
Merged
Merged
Conversation
westonpace
force-pushed
the
feat/repdef
branch
from
October 8, 2024 13:22
6835261 to
d216677
Compare
westonpace
force-pushed
the
feat/repdef
branch
4 times, most recently
from
October 15, 2024 15:31
200acf0 to
65b00c1
Compare
westonpace
force-pushed
the
feat/repdef
branch
from
October 18, 2024 22:47
5c685c0 to
ac98d0b
Compare
westonpace
marked this pull request as ready for review
October 18, 2024 22:47
westonpace
requested review from
broccoliSpicy and
wjones127
and removed request for
broccoliSpicy
October 18, 2024 22:47
broccoliSpicy
approved these changes
Oct 22, 2024
broccoliSpicy
left a comment
Contributor
There was a problem hiding this comment.
test issues in lance datafusion, others LGTM
wjones127
approved these changes
Oct 22, 2024
Comment on lines
+533
to
+534
| // TODO: Not that trivial, we might have rep/def that we need to encode / decode still | ||
| todo!() |
Contributor
There was a problem hiding this comment.
Should these be filled in for this PR? Or are we just not writing them yet so it doesn't matter?
Member
Author
There was a problem hiding this comment.
Yeah, there are a fair number of TODO's in this PR that I'm leaving for future PRs.
westonpace
force-pushed
the
feat/repdef
branch
from
October 24, 2024 15:48
9cd485b to
9a9748f
Compare
Cleanup after rebase Add a few more benchmarks Fix various bugs in page size / batch size / validity handling Add copyright header
westonpace
force-pushed
the
feat/repdef
branch
from
October 25, 2024 00:09
9a9748f to
ab0b936
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2968 +/- ##
==========================================
+ Coverage 78.24% 78.30% +0.05%
==========================================
Files 240 240
Lines 77284 78355 +1071
Branches 77284 78355 +1071
==========================================
+ Hits 60470 61354 +884
- Misses 13696 13902 +206
+ Partials 3118 3099 -19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlike the write path we were not able to get away with subtle changes to the existing traits. Most of the read traits needed to be duplicated. On the bright side, there is very little impact to the existing reader code though :)