fix: failed to write FTS index if the entire posting list is deleted - #4156
Merged
Conversation
Signed-off-by: BubbleCal <bubble-cal@outlook.com>
Signed-off-by: BubbleCal <bubble-cal@outlook.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4156 +/- ##
==========================================
+ Coverage 80.10% 80.14% +0.04%
==========================================
Files 292 292
Lines 100582 100651 +69
Branches 100582 100651 +69
==========================================
+ Hits 80569 80666 +97
+ Misses 17048 17023 -25
+ Partials 2965 2962 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BubbleCal
marked this pull request as ready for review
July 7, 2025 07:25
Xuanwo
reviewed
Jul 7, 2025
Xuanwo
left a comment
Collaborator
There was a problem hiding this comment.
Thank you @BubbleCal for working on this. PR LGTM and I only have some nitpick.
Signed-off-by: BubbleCal <bubble-cal@outlook.com>
BubbleCal
added a commit
that referenced
this pull request
Aug 14, 2025
We've seen some bugs that could be reproduced with some operations in some order, so adding this for finding out such bugs: - #4108 - #4156 - #3769 These weekly tests would enumerate all permutations of write operations, and run all of them, to make sure we can cover all cases. And we would run these tests on latest 2 stable version and main, to find out any regression and compatibility issues This would take a long time, so we run these weekly, rather than on each commit. and we've seen some bugs which happened on only large dataset, we can run some tests over a large dataset weekly, but not adding these for now --------- Signed-off-by: BubbleCal <bubble-cal@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.