ci: add memory and io benchmarks for building indices - #5483
Merged
Merged
Conversation
Contributor
Author
|
Some kind of interesting results so far: This probably needs some work to get helpful input data. The BITMAP index data needs lower cardinality to be representative and the FTS index data needs to have actual common keywords. |
Contributor
Author
|
New results: |
wjones127
force-pushed
the
io_bench_index
branch
from
December 16, 2025 20:37
2bda621 to
90a0c4f
Compare
wjones127
commented
Dec 16, 2025
Comment on lines
-2934
to
+3095
| vec![234, 107], | ||
| vec![220, 152], | ||
| vec![21, 16, 184, 220] | ||
| vec![174, 178], | ||
| vec![64, 122, 207, 248], | ||
| vec![124, 3, 58] |
Contributor
Author
There was a problem hiding this comment.
This changed because we re-use the same RNG across arrays, and we changed how random_sentence uses the RNG to a different distribution and thus changes the state differently.
wjones127
marked this pull request as ready for review
December 16, 2025 20:46
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
wjones127
added a commit
that referenced
this pull request
Jul 31, 2026
`test_rand_batches` only exercised byte sizing, leaving the new `rows_per_batch` mode and its mutual exclusion with `batch_size_bytes` untested. Adds a row-mode case and a rejection case. The existing byte-sizing test asserted `len()` on the return value, which has been a `RecordBatchReader` since #5483 — it raised `TypeError` whenever it ran. It only ever runs in a `--features datagen` build, and no CI job both enables that feature and collects `python/tests`, so the breakage went unnoticed. It now reads from the reader. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds basic memory and IO benchmarks for building indices. These are used for regression tests.