refactor: add exact current-format writers - #8022
Merged
Merged
Conversation
…mat-identity # Conflicts: # rust/lance-file/src/reader.rs # rust/lance/src/dataset/transaction.rs
… xuanwo/exact-version-stack-05-file-runtime
…rsion-stack-02-fixtures
…ct-version-stack-03-v1
…sion-stack-04-encoding-mechanisms
… xuanwo/exact-version-stack-05-file-runtime
This was referenced Jul 27, 2026
Base automatically changed from
xuanwo/exact-version-stack-04-encoding-mechanisms
to
main
July 30, 2026 16:44
Xuanwo
marked this pull request as ready for review
July 30, 2026 19:15
BubbleCal
approved these changes
Jul 31, 2026
Xuanwo
added a commit
that referenced
this pull request
Jul 31, 2026
Part 6/12 of #7877. Depends on #8022. This is an independently reviewable step toward the final layout demonstrated in #7979. This PR switches the public file writer boundary to exact-version dispatch. The root `FileWriter` becomes type erasure plus forwarding, while V1 and each current format own construction and behavior inside their version modules. Writer call sites in Lance, indexes, Python, and Java now pass an exact `ConcreteFileVersion`. This removes version-conditioned behavior from the shared current-format writer and makes every temporary, shuffle, merge, and dataset file creation site choose a format explicitly. Reader dispatch is intentionally deferred to the next PR. Validation: - `cargo clippy --all --tests --benches -- -D warnings` - `uv run make build` in `python/` - `cargo check --manifest-path java/lance-jni/Cargo.toml` - exact-version compatibility fixture tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 5/12 of #7877. Depends on #8021.
This is an independently reviewable step toward the final layout demonstrated in #7979.
This PR adds writer implementations owned by
versions::v2_0,versions::v2_1,versions::v2_2, andversions::v2_3. Each exact version composes the mechanisms it supports; genuinely shared structural machinery remains under the version-neutral writer module.Some composition code is intentionally repeated across adjacent versions. That repetition is the isolation boundary: changing a newer version must not silently change an older version. Public writer dispatch is left unchanged in this step and is activated by the next PR.
Validation:
cargo clippy --all --tests --benches -- -D warningscargo fmt --all -- --check