refactor!: compose exact current-format readers - #8024
Merged
Conversation
…mat-identity # Conflicts: # rust/lance-file/src/reader.rs # rust/lance/src/dataset/transaction.rs
… xuanwo/exact-version-stack-05-file-runtime
…rsion-stack-02-fixtures
…ct-version-stack-03-v1
…sion-stack-04-encoding-mechanisms
… xuanwo/exact-version-stack-05-file-runtime
…/exact-version-stack-06-writers
…t-version-stack-07-readers
This was referenced Jul 27, 2026
Xuanwo
marked this pull request as ready for review
July 31, 2026 18:22
…stack-07-readers # Conflicts: # rust/lance-encoding/benches/common/mod.rs # rust/lance-encoding/src/array_encoding/physical/bitpack.rs # rust/lance-encoding/src/array_encoding/physical/fixed_size_binary.rs # rust/lance-encoding/src/array_encoding/strategy.rs # rust/lance-encoding/src/compression.rs # rust/lance-encoding/src/encoder.rs # rust/lance-encoding/src/encodings/logical/primitive/sparse/writer.rs # rust/lance-encoding/src/lib.rs # rust/lance-encoding/src/testing.rs # rust/lance-file/src/lib.rs # rust/lance-file/src/reader.rs # rust/lance-file/src/version.rs # rust/lance-file/src/versions/mod.rs # rust/lance-file/src/versions/v1/encoding/plain.rs # rust/lance-file/src/versions/v1/mod.rs # rust/lance-file/src/versions/v2_0/mod.rs # rust/lance-file/src/versions/v2_0/writer.rs # rust/lance-file/src/versions/v2_1/compression.rs # rust/lance-file/src/versions/v2_1/mod.rs # rust/lance-file/src/versions/v2_2/compression.rs # rust/lance-file/src/versions/v2_2/mod.rs # rust/lance-file/src/versions/v2_3/compression.rs # rust/lance-file/src/versions/v2_3/mod.rs # rust/lance-file/src/writer.rs # rust/lance-file/src/writer/structural.rs # rust/lance-file/src/writer_tests.rs # rust/lance-file/test_data/exact_versions/README.md # rust/lance-index/src/scalar/lance_format.rs # rust/lance-index/src/vector/utils.rs # rust/lance-table/src/format.rs # rust/lance-table/src/format/manifest.rs # rust/lance/src/dataset.rs # rust/lance/src/dataset/builder.rs # rust/lance/src/dataset/fragment.rs # rust/lance/src/index/vector/ivf.rs # rust/lance/src/index/vector/ivf/io.rs # rust/lance/src/index/vector/pq.rs
Contributor
There was a problem hiding this comment.
The exact-version reader roots address a real file-format boundary: V2.0–V2.3 now validate their own footer identity, encoding grammar, alignment, projection shape, and metadata capabilities while shared I/O and decode machinery stays centralized. The stable wire contracts remain covered through exact-version fixtures, and I found no durable-format or correctness blocker.
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
BubbleCal
reviewed
Aug 4, 2026
| if gbo_table.is_empty() { | ||
| return Err(Error::internal( | ||
| "File did not contain any global buffers, schema expected".to_string(), | ||
| )); | ||
| } | ||
| let schema_start = gbo_table[0].position; | ||
| let schema_size = gbo_table[0].size; | ||
|
|
||
| let num_footer_bytes = file_len - schema_start; |
Contributor
There was a problem hiding this comment.
Could we validate the GBO descriptors before using them to build ranges? Here schema_start comes from the file and is used in file_len - schema_start before finish_metadata applies the V2.1+ alignment check. A malformed file can therefore underflow here (or wrap in release) and turn into an oversized read/allocation instead of InvalidInputSource. The indexed-metadata path has the same issue with position + size. Please validate alignment and file bounds with checked arithmetic immediately after decoding the GBO table, before either path performs I/O.
Collaborator
Author
There was a problem hiding this comment.
Should this be a follow-up issue? This series is a one-to-one mapping of the old logic and was not intended to change anything else except the code layout.
BubbleCal
approved these changes
Aug 4, 2026
Xuanwo
added a commit
that referenced
this pull request
Aug 4, 2026
## Why Main CI broke after #8024 landed: `ReaderProjection::from_column_names` / `from_whole_schema` were removed, but IVF index call sites still used them, so Rust, Java JNI, and Python builds failed to compile. Separately, newly published RUSTSEC advisories caused `cargo-deny` to fail on unpinned transitive crates. ## What - Switch remaining IVF readers/tests to `lance_file::versions::reader_projection_from_*` - Bump fixable transitive deps (`anyhow`, `event-listener`, `memmap2`, `rkyv`, `spin`) in all three lockfiles - Ignore `RUSTSEC-2026-0002` for `lru` 0.12.x until `goosefs-sdk` upgrades
Xuanwo
added a commit
that referenced
this pull request
Aug 5, 2026
Part 8/12 of #7877. Depends on #8024. This is an independently reviewable step toward the final layout demonstrated in #7979. This PR introduces the dataset-level write policy boundary under `dataset::versions`. Create, append, overwrite, update, merge-insert, fragment writing, and commit paths resolve the target exact format once and delegate version-specific writer construction through that boundary. Append continues to inherit the manifest format, overwrite continues to accept the selected target, and unsupported operations remain explicit. The file layer is no longer asked to infer dataset policy. Broader read and operation policy migration is intentionally left to part 10. Validation: - dataset write format-version tests - file write format-version tests - `cargo clippy --all --tests --benches -- -D warnings`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 7/12 of #7877. Depends on #8023.
This is an independently reviewable step toward the final layout demonstrated in #7979.
This PR gives V2.0, V2.1, V2.2, and V2.3 explicit reader composition alongside V1. The root reader keeps shared runtime machinery and type-erased forwarding, but exact version modules own construction, decoder selection, and supported capabilities.
The large shared reader implementation is reduced to mechanisms that are actually common. Version-sensitive choices no longer depend on ordering comparisons or scattered conditions, and the reader still parses persisted identity once at the boundary.
Validation:
cargo test -p lance-filecargo clippy --all --tests --benches -- -D warningsuv run make buildinpython/cargo check --manifest-path java/lance-jni/Cargo.toml