refactor: make index file versions exact - #8028
Merged
Merged
Conversation
…mat-identity # Conflicts: # rust/lance-file/src/reader.rs # rust/lance/src/dataset/transaction.rs
… xuanwo/exact-version-stack-05-file-runtime
…rsion-stack-02-fixtures
…ct-version-stack-03-v1
…sion-stack-04-encoding-mechanisms
… xuanwo/exact-version-stack-05-file-runtime
…/exact-version-stack-06-writers
…t-version-stack-07-readers
…t-version-stack-08-dataset-write-policy
…o xuanwo/exact-version-stack-09-selector-ownership
…xuanwo/exact-version-stack-10-dataset-operations
…xuanwo/exact-version-stack-11-index-consumers
This was referenced Jul 27, 2026
…stack-10-dataset-operations # Conflicts: # rust/lance-encoding/benches/common/mod.rs # rust/lance-encoding/src/array_encoding/physical/bitpack.rs # rust/lance-encoding/src/array_encoding/physical/fixed_size_binary.rs # rust/lance-encoding/src/array_encoding/strategy.rs # rust/lance-encoding/src/compression.rs # rust/lance-encoding/src/encoder.rs # rust/lance-encoding/src/encodings/logical/primitive.rs # rust/lance-encoding/src/encodings/logical/primitive/sparse/writer.rs # rust/lance-encoding/src/lib.rs # rust/lance-encoding/src/testing.rs # rust/lance-file/src/reader.rs # rust/lance-file/src/version.rs # rust/lance-file/src/versions/mod.rs # rust/lance-file/src/versions/v1/encoding/plain.rs # rust/lance-file/src/versions/v1/mod.rs # rust/lance-file/src/versions/v2_0/mod.rs # rust/lance-file/src/versions/v2_0/reader.rs # rust/lance-file/src/versions/v2_0/writer.rs # rust/lance-file/src/versions/v2_1/compression.rs # rust/lance-file/src/versions/v2_1/mod.rs # rust/lance-file/src/versions/v2_2/compression.rs # rust/lance-file/src/versions/v2_2/mod.rs # rust/lance-file/src/versions/v2_3/compression.rs # rust/lance-file/src/versions/v2_3/mod.rs # rust/lance-file/src/writer.rs # rust/lance-file/src/writer/structural.rs # rust/lance-file/src/writer_tests.rs # rust/lance-file/test_data/exact_versions/README.md # rust/lance-index/src/vector/hnsw/builder.rs # rust/lance-index/src/vector/utils.rs # rust/lance-table/src/format.rs # rust/lance-table/src/format/fragment.rs # rust/lance-table/src/format/manifest.rs # rust/lance-table/src/io/commit.rs # rust/lance/src/dataset.rs # rust/lance/src/dataset/builder.rs # rust/lance/src/dataset/fragment.rs # rust/lance/src/dataset/fragment/write.rs # rust/lance/src/dataset/index.rs # rust/lance/src/dataset/mem_wal/memtable/flush.rs # rust/lance/src/dataset/optimize.rs # rust/lance/src/dataset/optimize/binary_copy.rs # rust/lance/src/dataset/scanner.rs # rust/lance/src/dataset/schema_evolution.rs # rust/lance/src/dataset/statistics.rs # rust/lance/src/dataset/tests/dataset_index.rs # rust/lance/src/dataset/tests/dataset_io.rs # rust/lance/src/dataset/tests/dataset_merge_update.rs # rust/lance/src/dataset/tests/dataset_overlay_index_masking.rs # rust/lance/src/dataset/transaction.rs # rust/lance/src/dataset/updater.rs # rust/lance/src/dataset/versions/mod.rs # rust/lance/src/dataset/write.rs # rust/lance/src/dataset/write/commit.rs # rust/lance/src/dataset/write/insert.rs # rust/lance/src/dataset/write/merge_insert.rs # rust/lance/src/index/vector/ivf/io.rs # rust/lance/src/index/vector/pq.rs # rust/lance/src/io/commit.rs # rust/lance/src/io/commit/conflict_resolver.rs
…stack-10-dataset-operations # Conflicts: # rust/lance-table/src/io/commit.rs
…stack-10-dataset-operations
…stack-10-dataset-operations
…stack-10-dataset-operations # Conflicts: # rust/lance/src/dataset/transaction.rs
Base automatically changed from
xuanwo/exact-version-stack-10-dataset-operations
to
main
August 11, 2026 06:38
…xuanwo/exact-version-stack-11-index-consumers # Conflicts: # java/lance-jni/src/blocking_dataset.rs # rust/lance-file/src/version.rs
…stack-11-index-consumers
Xuanwo
marked this pull request as ready for review
August 11, 2026 08:00
Contributor
There was a problem hiding this comment.
✅ Gate recommendation: approve.
The change puts persisted format identity at the correct boundary: dataset and shard metadata now flow as exact versions through index writers and reader dispatch, while legacy V1→V2.0 and the fixed V2.1 two-file shuffle contract remain intact. This is preferable to retaining selector round-trips, which would leave future release-policy aliases able to affect persisted dispatch.
Please mark this PR with the breaking-change label.
BubbleCal
approved these changes
Aug 11, 2026
…stack-11-index-consumers # Conflicts: # rust/lance-table/src/io/commit/external_manifest.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 11/12 of #7877. Depends on #8027.
This is an independently reviewable step toward the final layout demonstrated in #7979.
This PR converts scalar and vector index readers, writers, shufflers, and distributed mergers to exact
ConcreteFileVersionidentities. Dataset-backed indexes inherit the dataset format explicitly; legacy dataset physical indexes map explicitly to V2.0.With the last transitional consumers migrated, this PR removes file-version ordering and implicit conversions between selectors and exact formats. Remaining version decisions are exhaustive matches at declared boundaries rather than
>=,max, or selector round-trips.Validation:
cargo clippy --all --tests --benches -- -D warnings