fix(io): stabilize wrapper identity in object store cache - #8068
Merged
Conversation
Xuanwo
marked this pull request as ready for review
July 29, 2026 08:10
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
BubbleCal
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ObjectStoreParamscurrently uses the full fat pointer ofArc<dyn WrappingObjectStore>as the cache identity. Trait-object vtable addresses can differ across codegen units even when both values point to the sameArcallocation. Equivalent parameters can therefore compare unequal and split the object-store registry cache; formemory://, the miss creates a fresh empty store and concurrent dataset operations can fail withDatasetNotFoundunder optimized builds.Wrapper cache identity should follow the underlying
Arcallocation rather than vtable metadata so the same wrapper reliably reuses the same store.