fix: support bitwise shift SQL expressions - #8388
Merged
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
# Conflicts: # rust/lance-datafusion/Cargo.toml
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…er/fix-3524-1 # Conflicts: # rust/lance-datafusion/Cargo.toml
Contributor
There was a problem hiding this comment.
✅ Gate recommendation: approve.
The latest merge from main preserves parser and planner support for both shift directions while retaining the optional datagen feature setup. Focused UInt64 coverage still exercises both operators through physical evaluation.
wjones127
self-requested a review
August 19, 2026 21:16
wjones127
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The custom Lance SQL dialect wrapped GenericDialect but inherited the Dialect trait default that disables bitwise shift operators. Once parsing is enabled, the Lance planner also needs explicit mappings for the resulting sqlparser shift operators.
Validation
cargo test -p lance-datafusioncargo fmt --all -- --checkcargo clippy --all --tests --benches -- -D warningsFixes #3524