fix(indexing): write FTS metadata even without partitions - #8482
Merged
westonpace merged 3 commits intoAug 11, 2026
Conversation
During a distributed FTS index build, write canonical metadata even when no partitions are produced. This distinguishes a valid empty index segment from a failed or incomplete build.
cmccabe
force-pushed
the
colin_write_metadata_without_parts
branch
from
August 11, 2026 18:11
802dd82 to
90a7983
Compare
Contributor
|
@cmccabe emmm wonder do we support search those empty partition FTS yet.... |
Contributor
There was a problem hiding this comment.
✅ Gate recommendation: approve.
The reviewed FTS fix remains unchanged, and the additional transaction-test edits use the canonical file-version resolver without altering behavior. A finalized FTS segment with no partitions is supported: its end-to-end search returns an empty result rather than an error.
Contributor
Author
|
@LuQQiu : we do actually test loading an empty index in |
LuQQiu
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During a distributed FTS index build, write canonical metadata even when no partitions are produced. This distinguishes a valid empty index segment from a failed or incomplete build.