Skip to content

fix for latest php7 head - #13

Merged
laruence merged 1 commit into
laruence:masterfrom
hjanuschka:hj
Feb 2, 2015
Merged

laruence merged 1 commit into
laruence:masterfrom
hjanuschka:hj

Conversation

@hjanuschka

Copy link
Copy Markdown
Contributor

hello

following changes enable compile against the current php7 master
there is no if-def-dance - so it does not compile on php5.6 5.5 - but should be a quick one - or maybe keep it in a seperate branch?

make test passes all tests - maybe this is a inspiration for someone who is doing the php-lua builds!

note includes @ktemkin 's config.m4 patch for debian/ubuntu

laruence added a commit that referenced this pull request Feb 2, 2015
fix for latest php7 head
@laruence
laruence merged commit a2e9c43 into laruence:master Feb 2, 2015
@hjanuschka

Copy link
Copy Markdown
Contributor Author

wow - fast - you sure it should be in the master branch? because it breaks building against any php version prior to php7-head?

could you add me to the LUA_AUTHORS (i forgot)

@laruence

laruence commented Feb 2, 2015

Copy link
Copy Markdown
Owner

I will make a new release before PHP7 comes out.

sure, maybe you could send another PR? I will merge it(author)

@laruence

laruence commented Feb 2, 2015

Copy link
Copy Markdown
Owner

maybe checkout a new branch for 5.x , of course before this commit

@hjanuschka

Copy link
Copy Markdown
Contributor Author

ok i have no clue how to re-open that pull request did a new one #14 for the authors stuff.

right now i don't have the need for php5.x - but i try to get a devbox up and running and try to do the backport.

regards

@zhang-bin zhang-bin mentioned this pull request Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants