fix for latest php7 head - #13
Merged
Merged
Conversation
Contributor
Author
|
wow - fast - you sure it should be in the master branch? because it breaks building against any php version prior to php7-head? could you add me to the LUA_AUTHORS (i forgot) |
Owner
|
I will make a new release before PHP7 comes out. sure, maybe you could send another PR? I will merge it(author) |
Owner
|
maybe checkout a new branch for 5.x , of course before this commit |
Contributor
Author
|
ok i have no clue how to re-open that pull request did a new one #14 for the authors stuff. right now i don't have the need for php5.x - but i try to get a devbox up and running and try to do the backport. regards |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hello
following changes enable compile against the current php7 master
there is no if-def-dance - so it does not compile on php5.6 5.5 - but should be a quick one - or maybe keep it in a seperate branch?
make test passes all tests - maybe this is a inspiration for someone who is doing the php-lua builds!
note includes @ktemkin 's config.m4 patch for debian/ubuntu