Use LRCLIB for lyrics with time-synced playback UI - #2
Draft
lasangainc wants to merge 4 commits into
Draft
Conversation
- Add LRCLIBLyricsService: GET /api/get with track signature, search fallback, LRC timestamp parsing, and recommended User-Agent header. - Mini player passes album, duration, and live playback position for matching and time-synced display. - New SyncedLyricsScrollView auto-scrolls with spring animation; active line uses glow, depth fade, and TimelineView shimmer when playing. - Plain lyrics use renamed PlainLyricsLineByLineView with LRCLIB attribution. - Remove Genius HTML lyric scraper. Co-authored-by: coolbanjo <lasangainc@users.noreply.github.com>
- Use periodic TimelineView with TimeInterval instead of animation + Duration.milliseconds, which failed to compile on the current SDK. - Drop await on synchronous actor cache writes (fixes redundant-await warnings). Co-authored-by: coolbanjo <lasangainc@users.noreply.github.com>
- Synced view drops capsule, glow, shimmer, and LRCLIB chip; active line is sharp semibold default design, others use blur + lower opacity. - Plain line-by-line view uses default design, similar blur for off-center lines, no attribution chip. - LRCLIB miss, fetch failure, or empty payload shows centered "..." placeholder; loading uses a small indeterminate progress only. - Remove unused isPlaying from the lyrics panel. Co-authored-by: coolbanjo <lasangainc@users.noreply.github.com>
- Bump synced sizes to 30pt current / 21pt others; plain lines 22–30pt by emphasis. - Replace smooth curves with high-bounce springs for scroll, line emphasis, and synced scale; initial scroll uses the same spring. - Reduce off-focus blur (synced max ~4.2, plain max ~5.5) and slightly raise inactive opacity for readability. Co-authored-by: coolbanjo <lasangainc@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /api/getusing track title, artist, album, and duration (seconds), withGET /api/searchas a fallback when there is no exact signature match.User-Agentheader (Lightify/<version> (wss.Lightify)).albumName,durationMs, and livepositionMs/isPlayingso LRCLIB can match tracks and the UI can stay in sync with playback.UI
...placeholder. Loading shows a smallProgressViewonly.Removed
GeniusLyricsServiceand the Genius folder (HTML/DOM parsing path).Build fixes
TimelineView(.periodic(from:by:))withTimeIntervalinstead ofanimation(minimumInterval: .milliseconds(…)), which did not compile on the project SDK.awaiton synchronousArtworkPipelinecache writes.