Skip to content

Give close buttons accessible names - #81

Merged
ldbumble merged 5 commits into
ldbumble:masterfrom
1cbyc:1cbyc/61-label-close-buttons
Sep 28, 2026
Merged

ldbumble merged 5 commits into
ldbumble:masterfrom
1cbyc:1cbyc/61-label-close-buttons

Conversation

@1cbyc

@1cbyc 1cbyc commented Sep 26, 2026

Copy link
Copy Markdown
Contributor

What & why

Give every IconButton containing a close icon an explicit, context-specific accessible name so screen readers no longer announce indistinguishable generic buttons. Add a source-scan regression and rebuild the packaged UI.

Fixes #61

Checklist

  • npm test passes (728 tests)
  • New behavior has a source-scan regression covering every JSX close icon button
  • UI touched → taskuary/web/ rebuilt and committed
  • No visual change; screenshot is unchanged
  • README not needed

Co-authored-by: insisong emmanuelisaacnsisong@gmail.com

Co-authored-by: insisong <emmanuelisaacnsisong@gmail.com>
ldbumble added a commit that referenced this pull request Sep 28, 2026
…red it and what you approve

A PR card showed who asked (the lead) and the reply to approve, but not what the agent found - that
lived only inside a sentence. The card keeps its layout and adds one line between the two: "coder
did: Reviewed PR #81: accept - ...". The rail's card now carries the agent's summary as `summary`,
as the older walk always did, so the chat's no-AI line reads it too.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ldbumble and others added 4 commits September 28, 2026 08:20
Only the built bundle conflicted; the source merged cleanly and the bundle
was rebuilt from the merged source.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Only the built bundle conflicted; the source merged cleanly and the bundle
was rebuilt from the merged source.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ldbumble
ldbumble merged commit ce57f6a into ldbumble:master Sep 28, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Close buttons in the web UI have no accessible name

2 participants