Forward SMS content to Feishu notifications - #1
Merged
Conversation
Owner
Author
|
Review completed: no feature-blocking findings. The per-SMS Feishu delivery, replay suppression, provider isolation, bounded independent contexts, privacy boundary, multipart validation, and co-located tests match the approved contract. CI note: compose-contract and all three image builds passed. The verify job fails only at govulncheck because the repository baseline pins Go 1.26.5; the latest main run fails on the same five standard-library advisories, all fixed in Go 1.26.6. This PR does not change the toolchain, so that separate baseline upgrade is intentionally not mixed into this feature change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Safety and compatibility
Verification
go test -count=1 ./internal/application/messaging ./internal/application/notificationgo test -race -count=1make check-formatmake verify-generatedmake lintmake testmake check-docsgit diff --check