Add table flag#37
Closed
duc0905 wants to merge 12 commits into
Closed
Conversation
…nto add_pretty_flag
JaDogg
suggested changes
Dec 7, 2019
| } | ||
| let finalTable = new Table({ | ||
| chars: { | ||
| top: "═", |
Member
There was a problem hiding this comment.
Can you extract these configs to a constant instead of duplicating it across both functions?
| // making the body of the table | ||
| for (prop in data) { | ||
| if (typeof data[prop] == "object") { | ||
| if (Array.isArray(data[prop])) body.push(tablerForArray(data[prop])); |
Member
There was a problem hiding this comment.
Can you use curly braces here. This is unreadable.
| } else if (typeof data == "object") { | ||
| return tablerForObject(data); | ||
| } else { | ||
| console.log( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create --table flag to print outputs in table format
Use Awsmock for testing
Change callback functions in services.js to run properly
Github link: https://github.com/duc0905/nodecloud-cli/tree/add_table_flag