Resolve #3398 Add flag to disable sourcemap url annotation - #3517
Merged
matthew-dean merged 2 commits intoJun 17, 2020
Merged
Conversation
hirosato
marked this pull request as draft
June 13, 2020 07:00
hirosato
force-pushed
the
add-flag-to-disable-sourcemap-url-annotation
branch
from
June 13, 2020 07:13
458d2d3 to
1c4c51a
Compare
hirosato
marked this pull request as ready for review
June 13, 2020 07:13
Member
|
"Disable" seems ok since having the annotation present by default is the intuited (default) behavior. |
Contributor
Author
I get it. thank you for review and comment. |
megheaiulian
added a commit
to plumelo/rollup-plugin-styler
that referenced
this pull request
Jul 29, 2026
less 4.5.1+ (PR less/less.js#4378) auto-derives sourceMapFilename and emits a /*# sourceMappingURL=style.css.map */ annotation into res.css even when the caller only wants res.map. The plugin then appends its own inline /*# sourceMappingURL=data:application/json;base64,... */ comment, producing two sourceMappingURL comments in the output. Pass disableSourcemapAnnotation: true (available since less 3.12.0, PR less/less.js#3517) to suppress the less-emitted annotation while keeping res.map intact. Cast to Less.SourceMapOption because @types/less does not include the flag. Remaining 7 snapshot updates reflect two intentional upstream changes: - query-string 9.1->9.4: now correctly parses URLs with query/fragment, so the url resolver applies publicPath to bg.png?query#hash (3 snaps) - rollup 4.52->4.62: manualChunks now sorted by module execution order instead of alphabetical alias name (PR rollup#6240) (4 snaps)
github-actions Bot
pushed a commit
to plumelo/rollup-plugin-styler
that referenced
this pull request
Jul 31, 2026
# [2.1.0](v2.0.0...v2.1.0) (2026-07-31) ### Bug Fixes * **less:** disable sourcemap annotation to prevent duplicate comments ([b5dc3ba](b5dc3ba)), closes [less/less.js#4378](less/less.js#4378) [less/less.js#3517](less/less.js#3517) [query#hash](https://github.com/query/issues/hash) [rollup#6240](https://github.com/rollup/issues/6240) * **test:** revert test script, rely on CI NODE_OPTIONS for ESM ([a0eb969](a0eb969)) * **typedoc:** update config ([cd0d808](cd0d808)) ### Features * **load-module:** support ESM-only packages with exports fields ([e2b2a27](e2b2a27))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small doubts
Shall I use positive form for the property? I mean using
appendSourcemapUrlAnnotation, for example, instead ofdisableSourcemapAnnotationsounds more straightforward for me. In other words,disableSourcemapAnnotation: false/truelooks a little bit confusing.--source-map-no-annotation, on the other hand, looks ok for me since it does not have true/false value with it.