Conversation
ghost
commented
Mar 4, 2017
| sr->tap_fname = fname; | ||
| } | ||
|
|
||
| int srunner_has_tap(SRunner * sr) |
Author
There was a problem hiding this comment.
It used srunner_tap_fname that is not defined before.
There was a problem hiding this comment.
It was already defined in src/check_log.h which is included in the beginning of src/check_log.c.
Contributor
There was a problem hiding this comment.
Maybe make this a separate commit, instead of combining multiple unrelated improvements in one commit.
ghost
commented
Mar 4, 2017
| #include <stdlib.h> | ||
| #include <fcntl.h> | ||
| #include <stdio.h> | ||
| #include <unistd.h> |
Contributor
There was a problem hiding this comment.
This header is not available if in the Windows environment. Because of this, the MSVC and Visual Studio build fails: https://ci.appveyor.com/project/brarcher46583/check/build/1.0.467.
Author
|
I removed from this pull request what I have split in an other one. #119 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.