Revert info.version to 2025-10-13 and document version-bump rule - #678
Closed
ls-bolt[bot] wants to merge 1 commit into
Closed
Revert info.version to 2025-10-13 and document version-bump rule#678ls-bolt[bot] wants to merge 1 commit into
ls-bolt[bot] wants to merge 1 commit into
Conversation
Set the OpenAPI spec info.version back to the initial 2025-10-13 and add a Critical Rules bullet: bump info.version only on a breaking change, matching a new servers.url path.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
shreyav
added a commit
that referenced
this pull request
Jul 10, 2026
## Summary - Revert the Grid API OpenAPI `info.version` from `2026-06-29` back to `2025-10-13`, the value it held on the initial schema commit. Edited the source `openapi/openapi.yaml` and rebundled (`make build`), so the generated `openapi.yaml` and `mintlify/openapi.yaml` are updated in lockstep. - Add a Critical Rules bullet to `CLAUDE.md` establishing the versioning convention: **bump `info.version` only when a breaking change ships, at which point it should match a new `servers.url` path**. ## Why The two prior bumps ([#617](#617): `2025-10-13` → `2026-06-25`, and [#633](#633): `2026-06-25` → `2026-06-29`) were both purely additive, non-breaking schema changes. Under the new convention the version should not have moved for those, so it's reset to `2025-10-13` — which matches the current `servers.url` path `https://api.lightspark.com/grid/2025-10-13`. ## Test plan - `make lint` passes (0 errors). - Verified `info.version` reads `2025-10-13` in all three files (`openapi/openapi.yaml`, `openapi.yaml`, `mintlify/openapi.yaml`). Requested by @shreyav Slack thread: https://lightsparkgroup.slack.com/archives/D0AH5T8FMGE/p1783708971530589 --- 🤖 [custodial-circuit](https://zeus.dev.dev.sparkinfra.net/#/arc?id=custodial-circuit)[(#1)](https://zeus.dev.dev.sparkinfra.net/#/instance?id=custodial-circuit) | [Feedback](https://zeus.dev.dev.sparkinfra.net/feedback) Original PR: #678
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
info.versionfrom2026-06-29back to2025-10-13, the value it held on the initial schema commit. Edited the sourceopenapi/openapi.yamland rebundled (make build), so the generatedopenapi.yamlandmintlify/openapi.yamlare updated in lockstep.CLAUDE.mdestablishing the versioning convention: bumpinfo.versiononly when a breaking change ships, at which point it should match a newservers.urlpath.Why
The two prior bumps (#617:
2025-10-13→2026-06-25, and #633:2026-06-25→2026-06-29) were both purely additive, non-breaking schema changes. Under the new convention the version should not have moved for those, so it's reset to2025-10-13— which matches the currentservers.urlpathhttps://api.lightspark.com/grid/2025-10-13.Test plan
make lintpasses (0 errors).info.versionreads2025-10-13in all three files (openapi/openapi.yaml,openapi.yaml,mintlify/openapi.yaml).Requested by @shreyav
Slack thread: https://lightsparkgroup.slack.com/archives/D0AH5T8FMGE/p1783708971530589
🤖 custodial-circuit(#1) | Feedback