Skip to content

feat(customers): require businessInfo when creating a business customer - #716

Closed
ls-bolt[bot] wants to merge 1 commit into
mainfrom
07-20-require-business-info
Closed

feat(customers): require businessInfo when creating a business customer#716
ls-bolt[bot] wants to merge 1 commit into
mainfrom
07-20-require-business-info

Conversation

@ls-bolt

@ls-bolt ls-bolt Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

This PR has been claimed. The active PR is now #717.

Summary

Makes businessInfo a required field when creating a business customer via POST /customers.

Previously businessInfo was optional on BusinessCustomerCreateRequest, even though the nested object already requires legalName, taxId, and incorporatedOn. A business customer can't be meaningfully onboarded without it, so this tightens the schema to reject requests that omit it entirely.

Changes

  • openapi/components/schemas/customers/BusinessCustomerCreateRequest.yaml — add businessInfo to the required list on the business-specific allOf member. This applies only to the BUSINESS branch of the create request; individual customers are unaffected.
  • Regenerated openapi.yaml and mintlify/openapi.yaml via make build.

make lint passes (only pre-existing, unrelated schema-properties-* warnings remain).

Note: info.version / servers.url are unchanged — the spec date-version tracks published API versions, and bumping it implies a new server path, which is a separate coordinated rollout.

Requested by @shreyav

@ls-bolt ls-bolt Bot added the bolt label Jul 20, 2026
@vercel

vercel Bot commented Jul 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
grid-flow-builder Ignored Ignored Preview Jul 20, 2026 5:51pm
grid-wallet-demo Ignored Ignored Preview Jul 20, 2026 5:51pm

Request Review

@github-actions github-actions Bot added the breaking-change Introduces a breaking change to the OpenAPI spec label Jul 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Breaking OpenAPI changes detected

This PR introduces breaking changes to openapi.yaml:

API Changelog 2025-10-13 vs. 2025-10-13

API Changes

POST /customers

  • ⚠️ the request property oneOf[subschema #2: Business Customer Create Request]/allOf[subschema #3]/businessInfo became required

Detected by oasdiff. This PR will need approval from an API reviewer before merge.

akanter commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions

github-actions Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

✱ Stainless preview builds for grid

This PR will update the grid SDKs with the following commit messages.

cli

chore(internal): regenerate SDK with no functional changes

go

fix(types): make BusinessInfo required in business customer creation

kotlin

fix(types): make businessInfo required in BusinessCustomerCreateRequest

openapi

fix(types): make businessInfo required in BusinessCustomerCreateRequest

php

fix(types): make businessInfo required in BusinessCustomerCreateRequest

python

fix(types): make business_info required in business customer creation

ruby

fix(types): make business_info required in BusinessCustomerCreateRequest

typescript

fix(types): make businessInfo required in BusinessCustomerCreateRequest

Edit this comment to update them. They will appear in their respective SDK's changelogs.

⚠️ grid-typescript studio · code · diff

Your SDK build had a failure in the lint CI job, which is a regression from the base state.
generate ✅build ✅ (prev: build ⏭️) → lint ❗ (prev: lint ⏭️) → test ✅

npm install https://pkg.stainless.com/s/grid-typescript/8b3bfad9cdc13143b3f3014fb3ec0256e5b54aee/dist.tar.gz
grid-ruby studio · code · diff

Your SDK build had at least one "note" diagnostic, but this did not represent a regression.
generate ✅build ✅lint ✅test ✅

grid-go studio · code · diff

Your SDK build had at least one "note" diagnostic, but this did not represent a regression.
generate ✅build ✅lint ❗test ❗

go get github.com/stainless-sdks/grid-go@f8e98a75568f003540e77ebcfdc8f2496fcca6e8
grid-kotlin studio · code · diff

Your SDK build had at least one "warning" diagnostic, but this did not represent a regression.
generate ⚠️build ✅lint ✅test ❗

grid-python studio · code · diff

Your SDK build had at least one "note" diagnostic, but this did not represent a regression.
generate ✅build ✅lint ❗test ❗

pip install https://pkg.stainless.com/s/grid-python/632c6f57434f573e72a17545d435344505d4cdd8/grid-0.0.1-py3-none-any.whl
grid-php studio · code · diff

Your SDK build had at least one "note" diagnostic, but this did not represent a regression.
generate ✅lint ✅test ✅

grid-cli studio · code · diff

Your SDK build had at least one "warning" diagnostic, but this did not represent a regression.
generate ⚠️build ❗lint ❗test ❗

grid-openapi studio · code · diff

Your SDK build had at least one "warning" diagnostic, but this did not represent a regression.
generate ⚠️


This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push.
If you push custom code to the preview branch, re-run this workflow to update the comment.
Last updated: 2026-07-20 17:56:59 UTC

@mintlify

mintlify Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
Grid 🟢 Ready View Preview Jul 20, 2026, 5:53 PM

@shreyav shreyav closed this Jul 20, 2026
shreyav added a commit that referenced this pull request Jul 20, 2026
…er (#717)

## Summary

Makes `businessInfo` a required field when creating a business customer
via `POST /customers`.

Previously `businessInfo` was optional on
`BusinessCustomerCreateRequest`, even though the nested object already
requires `legalName`, `taxId`, and `incorporatedOn`. A business customer
can't be meaningfully onboarded without it, so this tightens the schema
to reject requests that omit it entirely.

## Changes

-
`openapi/components/schemas/customers/BusinessCustomerCreateRequest.yaml`
— add `businessInfo` to the `required` list on the business-specific
`allOf` member. This applies only to the `BUSINESS` branch of the create
request; individual customers are unaffected.
- Regenerated `openapi.yaml` and `mintlify/openapi.yaml` via `make
build`.

`make lint` passes (only pre-existing, unrelated `schema-properties-*`
warnings remain).

Note: `info.version` / `servers.url` are unchanged — the spec
date-version tracks published API versions, and bumping it implies a new
server path, which is a separate coordinated rollout.

Requested by @shreyav

Original PR: #716
@shreyav
shreyav deleted the 07-20-require-business-info branch July 20, 2026 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bolt breaking-change Introduces a breaking change to the OpenAPI spec

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants