docs(skill): drop remaining paymentRails from create examples - #752
Closed
ls-bolt[bot] wants to merge 1 commit into
Closed
docs(skill): drop remaining paymentRails from create examples#752ls-bolt[bot] wants to merge 1 commit into
ls-bolt[bot] wants to merge 1 commit into
Conversation
The spec-refresh removed paymentRails from account-types.md but missed the external-account create examples in SKILL.md and workflows.md, and Best Practices tip #10 still stated it was required. paymentRails is response-only, so the skill was instructing callers to send an invalid field on every fiat account create.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
jklein24
added a commit
that referenced
this pull request
Jul 27, 2026
## Summary Follow-up to the skill spec-refresh (#708). That PR removed the response-only `paymentRails` field from the create examples in `account-types.md`, but three references survived elsewhere and contradicted the fix: - `SKILL.md` — `"paymentRails": ["SPEI"]` in the external-account create example - `SKILL.md` — Best Practices tip #10 still asserted *"all fiat accounts require `paymentRails`"* - `references/workflows.md` — `"paymentRails": ["SPEI"]` and `"paymentRails": ["ACH"]` in two create bodies `paymentRails` is not an input on any `*ExternalAccountCreateInfo` schema — Grid selects the rail and returns it on the created account (`common/*AccountInfo.yaml`). Left as-is, the skill instructs callers to send an invalid field on every fiat account create, and tip #10 is high-weight guidance. Tip #10 now points at the field that *is* required (`beneficiary`) and states the rail is server-selected. ## Test plan Docs-only. Verified no `paymentRails` remains in any request body across the skill (the 3 surviving mentions all describe it as response-only), and all 25 curl JSON bodies still parse. Requested by @jklein24 Original PR: #752
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the skill spec-refresh (#708). That PR removed the response-only
paymentRailsfield from the create examples inaccount-types.md, but three references survived elsewhere and contradicted the fix:SKILL.md—"paymentRails": ["SPEI"]in the external-account create exampleSKILL.md— Best Practices tip Update all product names to just Grid #10 still asserted "all fiat accounts requirepaymentRails"references/workflows.md—"paymentRails": ["SPEI"]and"paymentRails": ["ACH"]in two create bodiespaymentRailsis not an input on any*ExternalAccountCreateInfoschema — Grid selects the rail and returns it on the created account (common/*AccountInfo.yaml). Left as-is, the skill instructs callers to send an invalid field on every fiat account create, and tip #10 is high-weight guidance.Tip #10 now points at the field that is required (
beneficiary) and states the rail is server-selected.Test plan
Docs-only. Verified no
paymentRailsremains in any request body across the skill (the 3 surviving mentions all describe it as response-only), and all 25 curl JSON bodies still parse.Requested by @jklein24