Skip to content
This repository was archived by the owner on Jul 10, 2025. It is now read-only.

Changes to build against owntone-server release#51

Merged
Roxedus merged 1 commit into
linuxserver:masterfrom
dhutchison:bug/owntone-build
Jul 21, 2021
Merged

Changes to build against owntone-server release#51
Roxedus merged 1 commit into
linuxserver:masterfrom
dhutchison:bug/owntone-build

Conversation

@dhutchison

Copy link
Copy Markdown
Contributor

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

Changes paths in the build & links to refer to the new name of the project, owntone-server. As-is the main branch of this project does not build.

closes #50

Benefits of this PR and context:

Fixes #50.

How Has This Been Tested?

Verified that x86 image built and I could install & run the container.

Source / References:

Also fixes many links to refer to the new project name of owntone-server

closes linuxserver#50

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@LinuxServer-CI

Copy link
Copy Markdown
Contributor

@BernsteinA

Copy link
Copy Markdown
Contributor

This looks good to me.
Can I get a quick ok from you @aptalca before I merge?

@aptalca

aptalca commented Jul 20, 2021

Copy link
Copy Markdown
Member

@BernsteinA lgtm

@Roxedus Roxedus mentioned this pull request Jul 21, 2021
1 task
@BernsteinA

Copy link
Copy Markdown
Contributor

Ok so I don't know who has write permissions to merge this now...
cc @Roxedus

@Roxedus
Roxedus merged commit d5c7669 into linuxserver:master Jul 21, 2021
@Roxedus

Roxedus commented Jul 21, 2021

Copy link
Copy Markdown
Member

I got you

@BernsteinA

Copy link
Copy Markdown
Contributor

I don't know where to put this, but we should add a notice somewhere that pulling the latest image will create a new settings file owntone.conf and will not read from your existing forked-daapd.conf
Could be a very disruptive change for many users...

@BernsteinA

Copy link
Copy Markdown
Contributor

Maybe we should roll back this pr, and change the docker image name before applying it again?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New build of owntone failing on jenkins

5 participants