Skip to content

feat: Add outbound example - #237

Merged
nbsp merged 3 commits into
livekit:mainfrom
MatthiasGruba:outbound-example
Jan 4, 2025
Merged

nbsp merged 3 commits into
livekit:mainfrom
MatthiasGruba:outbound-example

Conversation

@MatthiasGruba

Copy link
Copy Markdown
Contributor

The example @mike-r-mclaughlin asked me in Slack to add here!

First contribution here so let me know if any changes are needed :)

@changeset-bot

changeset-bot Bot commented Jan 3, 2025 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: cbba7fb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant

CLAassistant commented Jan 3, 2025 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@nbsp nbsp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, apart from the build errors related to dependencies

Comment thread examples/src/outbound_example.ts
@MatthiasGruba

MatthiasGruba commented Jan 4, 2025 •

Copy link
Copy Markdown
Contributor Author

Ready for review again @nbsp - had to add livekit-server-sdk dependency to the examples package.json although I don't need this in my production code as it comes from @livekit/agents

@nbsp
nbsp merged commit aed2da2 into livekit:main Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants