Include job count in WorkerStatus and load_fnc - #1046
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 18225e8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
|
I think we should pass the Worker instance to the load_fnc, not just the number of jobs bc it seems very specific |
Member
|
Bump on this one :) |
Contributor
Author
|
ahh missed this, ok yeah that makes sense - will update |
theomonnom
reviewed
Nov 14, 2024
theomonnom
reviewed
Nov 14, 2024
theomonnom
reviewed
Nov 14, 2024
| signature = inspect.signature(self._opts.load_fnc) | ||
| parameters = list(signature.parameters.values()) | ||
| if len(parameters) == 0: | ||
| return self._opts.load_fnc() # type: ignore |
Member
There was a problem hiding this comment.
not sure about the type: ignore here
What are they used for?
Contributor
Author
There was a problem hiding this comment.
type:ignore is needed because it's not known which load_fnc we have, one with arg or one without?
theomonnom
reviewed
Nov 14, 2024
theomonnom
approved these changes
Nov 14, 2024
theomonnom
reviewed
Nov 14, 2024
theomonnom
approved these changes
Nov 14, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.