feat: add max_tokens option to LLM and LLMStream classes - #1544
Closed
dorlanpabon wants to merge 1 commit into
Closed
dorlanpabon wants to merge 1 commit into
dorlanpabon wants to merge 1 commit into
Conversation
|
|
juan.pabon seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
ronanmcnulty
pushed a commit
to GreyhoundRecyclingIreland/agents
that referenced
this pull request
Jul 23, 2026
Routine + handled on our deployment: post-completion re-emissions are dropped by design (livekit#6431/livekit#6481) and the worker's capture wrap folds the text into the stored transcript before this handler runs. The WARNING paged Rollbar on essentially every Gemini call (cai items livekit#1543/livekit#1544, livekit#1606/livekit#1607).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
max_tokensparameter to theLLMOptionsand related methods in thelivekit-plugins-openaiplugin. The changes ensure that themax_tokensparameter is properly integrated and used throughout the class methods.Key changes include:
livekit-plugins/livekit-plugins-openai/livekit/plugins/openai/llm.py:max_tokensparameter to theLLMOptionsclass.__init__method to accept and initialize themax_tokensparameter. [1] [2]with_groqmethod to include themax_tokensparameter. [1] [2]max_tokensparameter in the_runmethod to ensure it is passed correctly during execution.