(sarvam stt): fix end of speech timing - #6052
Merged
Merged
Conversation
theomonnom
approved these changes
Jun 11, 2026
chenghao-mou
approved these changes
Jun 11, 2026
chenghao-mou
left a comment
Member
There was a problem hiding this comment.
lgtm, one small nitpick.
| text=transcript_text, | ||
| start_time=start_time, | ||
| end_time=end_time, | ||
| start_time=self._positive_time(transcript_data.get("speech_start")) or 0.0, |
Member
There was a problem hiding this comment.
we can add the start_time_offset in _positive_time so that all values through that function includes session start -> audio start delay:
def _positive_time(self, value: object) -> float | None:
if isinstance(value, bool) or not isinstance(value, (int, float)):
return None
if value <= 0:
return None
return float(value) + self.start_time_offset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Sarvam streaming STT plugin tried to manufacture an audio-relative speech-end time from two sources that don't actually provide one:
Sarvam's streaming socket genuinely sends no usable word timing (no timestamps array; speech_start/speech_end come back null), so all this machinery produced misleading timestamps.
Change
Aligned Sarvam with how every other STT plugin (Deepgram, AssemblyAI, Google, Azure…) handles this: