Skip to content

fix: attribute playback evidence to its own segment on the same audio output - #6470

Merged
chenghao-mou merged 5 commits into
mainfrom
chenghao/fix/AGT-3147-playback-started-attribution
Aug 26, 2026
Merged

chenghao-mou merged 5 commits into
mainfrom
chenghao/fix/AGT-3147-playback-started-attribution

Conversation

@chenghao-mou

@chenghao-mou chenghao-mou commented Jul 17, 2026 •

Copy link
Copy Markdown
Member

Porting over livekit/agents-js#1966

Fixes AGT-3147

🤖 Generated with Claude Code

@chenghao-mou
chenghao-mou requested a review from a team as a code owner July 17, 2026 20:32

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

@chenghao-mou
chenghao-mou force-pushed the chenghao/fix/AGT-3147-playback-started-attribution branch from 30e2cd6 to fc6b29d Compare July 17, 2026 21:04
@chenghao-mou chenghao-mou changed the title fix: attribute playback evidence to its own segment on shared audio outputs fix: attribute playback evidence to its own segment on the same audio output Jul 17, 2026
@chenghao-mou
chenghao-mou requested a review from toubatbrian July 17, 2026 22:45
@chenghao-mou
chenghao-mou force-pushed the chenghao/fix/AGT-3147-playback-started-attribution branch from 8128c04 to 376e875 Compare August 26, 2026 12:35
chenghao-mou and others added 3 commits August 26, 2026 13:35
…k evidence to their own segment

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Drop own_segment_index and the snapshot+1 listener window; gate
playback_started on has_captured_own_frame and interrupted commits on a
segment-counter delta, matching the merged JS late-playback fix.

Co-authored-by: Cursor <cursoragent@cursor.com>
@chenghao-mou
chenghao-mou force-pushed the chenghao/fix/AGT-3147-playback-started-attribution branch from 376e875 to 7fde517 Compare August 26, 2026 12:36
@chenghao-mou
chenghao-mou merged commit e687cc2 into main Aug 26, 2026
21 of 23 checks passed
@chenghao-mou
chenghao-mou deleted the chenghao/fix/AGT-3147-playback-started-attribution branch August 26, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants