Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions auth/verifier.go
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,11 @@ func (v *APIKeyTokenVerifier) Verify(key interface{}) (*jwt.RegisteredClaims, *C
jwt.WithValidMethods(allowedSigningMethods),
jwt.WithIssuer(v.apiKey),
jwt.WithLeeway(tokenLeeway),
// Without this, a token carrying no exp claim passes validation and
// never expires. First-party SDKs always set exp, but any hand-rolled
// or third-party minter that forgets it silently mints a permanent
// credential.
jwt.WithExpirationRequired(),
)
if err != nil {
return nil, nil, err
Expand Down
20 changes: 20 additions & 0 deletions auth/verifier_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,26 @@ func TestVerifier(t *testing.T) {
require.Error(t, err)
})

t.Run("token without exp is rejected", func(t *testing.T) {
// hand-rolled JWT with no exp claim (the Go SDK always sets one, so
// build it directly to model a third-party minter forgetting exp)
token := jwt.NewWithClaims(jwt.SigningMethodHS256, jwt.MapClaims{
"iss": apiKey,
"nbf": jwt.NewNumericDate(time.Now().Add(-time.Minute)),
"video": map[string]interface{}{
"roomCreate": true,
},
})
authToken, err := token.SignedString([]byte(secret))
require.NoError(t, err)

v, err := auth.ParseAPIToken(authToken)
require.NoError(t, err)

_, _, err = v.Verify(secret)
require.Error(t, err)
})

t.Run("unexpired token is verified", func(t *testing.T) {
claim := auth.VideoGrant{RoomCreate: true}
at := auth.NewAccessToken(apiKey, secret).
Expand Down
Loading