Room feature usage - #1737
Merged
Merged
Conversation
Signed-off-by: shishir gowda <shishir@livekit.io>
Signed-off-by: shishir gowda <shishir@livekit.io>
|
shishirng
marked this pull request as draft
August 24, 2026 18:02
Signed-off-by: shishir gowda <shishir@livekit.io>
boks1971
approved these changes
Aug 25, 2026
| case livekit.FeatureUsageInfo_AIC_AUDIO_ENHANCEMENT: | ||
| // AIC enhancement is keyed by the specific feature metadata (<key>_<value>). | ||
| for k, v := range info.GetFeatureInfo() { | ||
| return fmt.Sprintf("%s_%s", k, v) |
Contributor
There was a problem hiding this comment.
Are there multiple here and returning first one is okay?
Contributor
Author
There was a problem hiding this comment.
yes, only one is reported at a time
barrust
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.