Skip to content

Update go deps (major) #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renovate wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

Update go deps (major) #298

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ require (
github.com/livekit/psrpc v0.7.3
github.com/livekit/server-sdk-go/v2 v2.18.2-0.20260821165736-9b5928e4fcb8
github.com/livekit/sipgo v0.13.2-0.20260519205735-a5b4a38b6ceb
github.com/mjibson/go-dsp v0.0.0-20180508042940-11479a337f12
github.com/ory/dockertest/v3 v3.12.0
github.com/pion/rtp v1.10.5
github.com/mjibson/go-dsp v1.0.0

@devin-ai-integration devin-ai-integration Bot Jul 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Build fails because dependency checksums were not updated

The go-dsp dependency version is changed to v1.0.0 (go.mod:18) but no matching checksum entry exists in the module checksum file, so the build fails with a missing checksum error.
Impact: The project fails to build/verify until the checksum file is regenerated.

go.sum not regenerated for go-dsp v1.0.0

go.mod:18 now requires github.com/mjibson/go-dsp v1.0.0, but go.sum still only contains the old pseudo-version v0.0.0-20180508042940-11479a337f12 and has no v1.0.0 entry. go build/go mod verify will fail with a missing go.sum entry. The import path is unchanged (github.com/mjibson/go-dsp/fft at pkg/audiotest/freq.go:23), so only go.sum needs regenerating via go mod tidy.

Prompt for agents 
go.mod bumped github.com/mjibson/go-dsp to v1.0.0, but go.sum was not regenerated and lacks a v1.0.0 entry (it still only has the old pseudo-version). Run go mod tidy to update go.sum. The import path is unchanged so no source edits are needed.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

github.com/ory/dockertest/v4 v4.0.0

@devin-ai-integration devin-ai-integration Bot Jul 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Docker test library import path mismatch causes test build failure

The dependency declaration was bumped to a new major version (github.com/ory/dockertest/v4 at go.mod:19) without updating the corresponding import paths in test files, so integration tests will fail to compile.

Impact: All integration tests cannot be built or run.

Import path mismatch details

The go.mod now declares github.com/ory/dockertest/v4 v4.0.0 but the old github.com/ory/dockertest/v3 was removed. Three test files still use the old v3 import path:

  • test/integration/docker_test.go:11 imports "github.com/ory/dockertest/v3"
  • test/integration/livekit_test.go:11 imports "github.com/ory/dockertest/v3"
  • test/integration/livekit_test.go:12 imports "github.com/ory/dockertest/v3/docker"
  • test/integration/docker_mac_test.go:12 imports "github.com/ory/dockertest/v3"

These imports need to be updated to "github.com/ory/dockertest/v4" (and v4/docker) to match the module path declared in go.mod.

Prompt for agents 
The go.mod was updated to use github.com/ory/dockertest/v4 v4.0.0 but the test source code still imports github.com/ory/dockertest/v3. Four import statements across three files need updating:

1. test/integration/docker_test.go line 11: change v3 to v4
2. test/integration/livekit_test.go line 11: change v3 to v4
3. test/integration/livekit_test.go line 12: change v3/docker to v4/docker
4. test/integration/docker_mac_test.go line 12: change v3 to v4

Also verify that the dockertest v4 API is compatible with how the Pool type and other APIs are used in these test files.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

github.com/pion/rtp/v2 v2.0.0

@devin-ai-integration devin-ai-integration Bot Jul 12, 2026 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Dependency version bumps leave the project unbuildable

The dependency list is switched to new major versions (github.com/ory/dockertest/v4, github.com/pion/rtp/v2 at go.mod:19-20) while all source files still use the old versions and the checksum file was never refreshed, so the project can no longer be built or tested.
Impact: Builds and tests fail immediately for everyone until the code and checksum file are updated.

Stale imports and missing go.sum entries after the major-version bumps
  • go.mod now requires github.com/ory/dockertest/v4 v4.0.0 and github.com/pion/rtp/v2 v2.0.0, but the code still imports the previous major versions: test/integration/docker_test.go:11, test/integration/docker_mac_test.go:12, test/integration/livekit_test.go:10-11 (github.com/ory/dockertest/v3), and pkg/media/rtpconn/conn.go:25, pkg/sip/media.go:24 (github.com/pion/rtp). Those module paths are no longer listed as requirements, so resolution fails.
  • go.sum was not regenerated: it still contains only github.com/ory/dockertest/v3 v3.12.0, github.com/pion/rtp v1.10.2 and github.com/mjibson/go-dsp v0.0.0-20180508042940-... (go.sum:149-150,177-178,197-198); there are no hashes for github.com/pion/rtp/v2 v2.0.0, github.com/ory/dockertest/v4 v4.0.0, or github.com/mjibson/go-dsp v1.0.0, which causes "missing go.sum entry" errors.
  • Note also that transitive dependencies (e.g. pion/webrtc/v4, pion/interceptor, livekit/media-sdk) still depend on github.com/pion/rtp v1, so both majors would need to coexist; simply swapping the requirement is not sufficient.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

github.com/pion/sdp/v3 v3.0.19
github.com/pion/webrtc/v4 v4.2.18
github.com/prometheus/client_golang v1.24.1
Expand Down
Loading