Skip to content

Update README.md - #6

Draft
JimLynchCodes wants to merge 1 commit into
ljharb:mainfrom
JimLynchCodes:patch-1
Draft

Update README.md#6
JimLynchCodes wants to merge 1 commit into
ljharb:mainfrom
JimLynchCodes:patch-1

Conversation

@JimLynchCodes

Copy link
Copy Markdown
  • Added an es6 import example

  • moved these examples to a better location (in the install section)

Comment thread README.md
var stringify = require('json-stable-stringify')
```

Es6 example:

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Es6 example:
ESM example:

Comment thread README.md

CommonJS example:
``` js
var stringify = require('json-stable-stringify')

@ljharb ljharb Dec 7, 2023

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
var stringify = require('json-stable-stringify')
const stringify = require('json-stable-stringify');

Comment thread README.md

Es6 example:
``` js
import stringify from 'json-stable-stringify'

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import stringify from 'json-stable-stringify'
import stringify from 'json-stable-stringify';

Comment thread README.md
npm install json-stable-stringify
```

CommonJS example:

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
CommonJS example:
CJS example:

@ljharb ljharb added the documentation Improvements or additions to documentation label Dec 7, 2023
@ljharb
ljharb marked this pull request as draft January 16, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants