Improvements to gdb-oneapi support - #53
Merged
Merged
Conversation
Replaced the MI command "-thread-info" with "thread apply" for retrieving the thread list. The previous MI command output could grow excessively large, making it inefficient for the readlines function to process. Now after this change the output of "thread apply" command is only a list of threads and will take less time in readlines function. The test file oneapi_gdb_test.py has been updated to test these changes. Signed-off-by: Abdul Basit Ijaz <abdul.b.ijaz@intel.com>
The backtrace command now uses the "with print frame-arguments none --" option to enhance performance, as frame argument details are unnecessary for the STAT tool. Signed-off-by: Abdul Basit Ijaz <abdul.b.ijaz@intel.com>
The "STAT_COLLECT_SIMD_BT" option in gdb-oneapi STAT support is used to add lane information in thread id. So, using this environment increases the STAT capture time due to sequential calls per lane of a thread for the collection of the call stack. It is removed in this change because the function call stacks collected for lanes are identical , except for function argument values, which are not taken into consideration by STAT anyway. Signed-off-by: Abdul Basit Ijaz <abdul.b.ijaz@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced the MI command "-thread-info" with "thread apply" for retrieving the thread list. The previous MI command output could grow excessively large, making it inefficient for the readlines function to process. Now after this change the output of "thread apply" command is only a list of threads and will take less time in readlines function.
The backtrace command now uses the "with print frame-arguments none --" option to enhance performance, as frame argument details are unnecessary for the STAT tool.
The "STAT_COLLECT_SIMD_BT" option in gdb-oneapi STAT support is used to add lane information in thread id. So, using this environment increases the STAT capture time due to sequential calls per lane of a thread for the collection of the call stack. It is removed in this change because the function call stacks collected for lanes are identical , except for function argument values, which are not taken into consideration by STAT anyway.