Skip to content

feat(visual): add lora field-notes system and hero gaze - #29

Merged
lora-sys merged 1 commit into
mainfrom
codex/lora-visual-v1
Aug 24, 2026
Merged

lora-sys merged 1 commit into
mainfrom
codex/lora-visual-v1

Conversation

@lora-sys

Copy link
Copy Markdown
Owner

Summary

  • add the lora-visual v1 registry, shared rendering/frame components, and full-site scene coverage
  • add the layered bilingual Hero gaze interaction with fine-pointer and reduced-motion fallbacks
  • refresh project covers, Harness diagrams, avatar, stamps, social card, favicon family, theme tokens, and GitHub cover mappings while retaining legacy assets

Verification

  • bun run check (0 errors, 0 warnings, 0 hints)
  • NODE_OPTIONS=--max-old-space-size=3072 bun run build (75 pages, release audit passed)
  • bun run validate:sync (69 projects, 5 contributions, 9 PRs, 0 failures, 0 warnings)
  • git diff --check
  • browser sweep across bilingual routes, desktop, 390px mobile, keyboard, themes, reduced motion, and Hero gaze reset
  • Lighthouse: desktop home/projects 100 performance and 100 accessibility; mobile home/projects 96/97 performance, CLS 0, TBT 0, accessibility 100

Review artifacts remain outside the repository. No dependency changes.

@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 290ea6a1-e277-47b7-9dd2-93fb04f4ead0


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ecc-tools

ecc-tools Bot commented Aug 24, 2026

Copy link
Copy Markdown

Analyzing 200 commits...

@lora-sys
lora-sys merged commit 9a6a772 into main Aug 24, 2026
1 check passed
@ecc-tools

ecc-tools Bot commented Aug 24, 2026

Copy link
Copy Markdown

Analysis Complete

Generated ECC bundle from 1 commits | Confidence: 65%

View Pull Request #30

Repository Profile
Attribute Value
Language TypeScript
Framework Not detected
Commit Convention conventional
Test Directory separate
Changed Files (104)
Metric Value
Files changed 104
Additions 1575
Deletions 819

Top hotspots

Path Status +/-
src/data/github-projects.json modified +1154 / -647
src/data/lora-visual.ts added +74 / -0
src/assets/styles/app.css modified +43 / -29
src/pages/index.astro modified +28 / -40
src/components/lora/HeroGazeScene.astro added +65 / -0

Top directories

Directory Files Total changes
src/data 4 1885
src/components/lora 7 181
src/assets/styles 1 72
src/pages 1 68
src/pages/en 6 39
Analysis Depth Readiness (commit-history, 7%)

ECC Tools uses this to decide whether recommendations should stay at commit-history/setup guidance or expand into CI, security, harness, reference-set, AI-routing, and team backlog work.

Area Status Evidence / Next Step
Commit history Partial 1 commits sampled
CI/CD signals Missing Add workflow files or CI troubleshooting evidence so ECC Tools can reason about pipeline setup.
Security evidence Missing Add AgentShield, audit, SARIF, SBOM, or security review evidence so recommendations can cover security posture.
Harness configuration Missing Add Claude, Codex, OpenCode, Zed, dmux, MCP, plugin, or cross-harness config evidence for harness-agnostic recommendations.
Reference/eval evidence Missing Add fixtures, golden traces, reference sets, or evaluator benchmarks so deeper recommendations have regression evidence.
AI routing and cost controls Missing Add model-routing, budget, usage, or cost-control files before relying on AI-heavy automation recommendations.
Team handoff and project tracking Missing Add roadmap, runbook, project, Linear, or follow-up tracking docs so generated work can land in a team queue.
Reference Set Readiness (0/7, 0%)
Area Status Evidence / Next Step
Deep analyzer corpus Missing Add analyzer fixture, golden, benchmark, or reference-set files that can catch analyzer regressions.
RAG/evaluator comparison Missing Add retrieval or evaluator reference-set comparison fixtures with expected ranking behavior.
PR salvage/review corpus Missing Add stale-PR, review-thread, reopen-flow, or salvage reference cases for queue cleanup automation.
Discussion triage corpus Missing Add public discussion triage fixtures, golden cases, or reference sets for informational, answered, and no-response classifications.
Harness compatibility Missing Add cross-harness, adapter-compliance, or harness-audit evidence for Claude, Codex, OpenCode, Zed, dmux, and agent surfaces.
Security evidence Missing Attach security evidence such as SBOMs, SARIF, audit reports, or AgentShield evidence packs.
CI failure-mode evidence Missing Add captured CI failure logs, dry-run fixtures, or troubleshooting docs for common workflow failure modes.
Likely Future Issues (3)
Severity Signal Why it may show up
HIGH Regression coverage may lag behind the diff 57 generic code paths changed; 0 test files changed
MEDIUM Runtime config changes may ship without example or template updates 1 runtime config paths changed; 0 example or template config files changed
MEDIUM User-facing UI changes may ship without browser coverage 35 user-facing UI paths changed; 0 browser or e2e coverage files changed
  • Regression coverage may lag behind the diff: The PR changes multiple code paths but does not touch any obvious test files.
  • Runtime config changes may ship without example or template updates: The PR changes runtime config or deployment settings but does not update any obvious example env file or config template.
  • User-facing UI changes may ship without browser coverage: The PR changes components, pages, or other user-facing UI files without touching any obvious browser or end-to-end coverage.
Suggested Follow-up Work (3)
Type Suggested title Targets
PR test: add regression coverage for scripts/fetch-github-projects.mjs + src/assets/lora-visual/v1/lora-v1-404-wayfinding.webp scripts/fetch-github-projects.mjs, src/assets/lora-visual/v1/lora-v1-404-wayfinding.webp
PR chore: sync config templates for src/site.config.ts src/site.config.ts
PR test: add browser coverage for src/assets/styles/app.css + src/components/BaseHead.astro src/assets/styles/app.css, src/components/BaseHead.astro
  • test: add regression coverage for scripts/fetch-github-projects.mjs + src/assets/lora-visual/v1/lora-v1-404-wayfinding.webp: Backfill regression coverage before another change set lands on the touched code paths.
  • chore: sync config templates for src/site.config.ts: Backfill example env files or config templates before a fresh setup drifts from the shipped runtime surface.
  • test: add browser coverage for src/assets/styles/app.css + src/components/BaseHead.astro: Backfill browser coverage before another user-facing UI change lands on the touched surface.

Copy-ready bodies

test: add regression coverage for scripts/fetch-github-projects.mjs + src/assets/lora-visual/v1/lora-v1-404-wayfinding.webp

## Summary
- Add regression coverage for the recently touched code paths before more changes stack on top.

## Why
- Backfill regression coverage before another change set lands on the touched code paths.

## Touched paths
- `scripts/fetch-github-projects.mjs`
- `src/assets/lora-visual/v1/lora-v1-404-wayfinding.webp`

## Validation
- Add or extend focused tests that exercise the touched paths.
- Run the affected test suite and verify the new coverage closes the gap.

chore: sync config templates for src/site.config.ts

## Summary
- Update the example env files, sample configs, or deployment templates that should mirror the changed runtime configuration surface.

## Why
- Backfill example env files or config templates before a fresh setup drifts from the shipped runtime surface.

## Touched paths
- `src/site.config.ts`

## Validation
- Update the repo example env file or config template that should reflect the new runtime settings.
- Run the setup, boot, or deployment validation flow that depends on the changed config surface.

test: add browser coverage for src/assets/styles/app.css + src/components/BaseHead.astro

## Summary
- Add browser or end-to-end coverage for the recently changed user-facing surface.

## Why
- Backfill browser coverage before another user-facing UI change lands on the touched surface.

## Touched paths
- `src/assets/styles/app.css`
- `src/components/BaseHead.astro`

## Validation
- Add or extend browser / e2e coverage for the changed component, page, or flow.
- Exercise the visible user journey that depends on the touched UI surface.
Generated Instincts (7)
Domain Count
git 2
code-style 3
architecture 1
testing 1

After merging, import with:

/instinct-import .claude/homunculus/instincts/inherited/loraSys-instincts.yaml

Files

  • .claude/ecc-tools.json
  • .claude/skills/loraSys/SKILL.md
  • .agents/skills/loraSys/SKILL.md
  • .agents/skills/loraSys/agents/openai.yaml
  • .claude/identity.json
  • .codex/config.toml
  • .codex/AGENTS.md
  • .codex/agents/explorer.toml
  • .codex/agents/reviewer.toml
  • .codex/agents/docs-researcher.toml
  • .claude/homunculus/instincts/inherited/loraSys-instincts.yaml

ECC Tools | Everything Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant