Skip to content

centerMode option added#763

Open
nishantuie wants to merge 9 commits into
loryjs:masterfrom
nishantuie:feature/center-mode
Open

centerMode option added#763
nishantuie wants to merge 9 commits into
loryjs:masterfrom
nishantuie:feature/center-mode

Conversation

@nishantuie

Copy link
Copy Markdown

Added centerMode option to enable centerMode functionality which is missing in current day implementation.

@nishantuie nishantuie changed the title Feature/center mode centerMode option added Jun 14, 2019
@nishantuie nishantuie mentioned this pull request Jun 14, 2019

@Saturate Saturate left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just took a quick look, you have some uncommented code included. I'll dig a little deeper soon, but I am quite busy at the current time. If people want to test and confirm that it works, that will also help me.

Thanks for contributing!

Comment thread static/app.css Outdated
@nishantuie
nishantuie requested a review from Saturate November 8, 2019 06:11
@Ankitpatel08

Copy link
Copy Markdown

Just took a quick look, you have some uncommented code included. I'll dig a little deeper soon, but I am quite busy at the current time. If people want to test and confirm that it works, that will also help me.

Thanks for contributing!

image

Verified, Works fine with variable width slides and great to have firstSlideLeftAligned feature.

@nishantuie

nishantuie commented Nov 12, 2019

Copy link
Copy Markdown
Author

Just took a quick look, you have some uncommented code included. I'll dig a little deeper soon, but I am quite busy at the current time. If people want to test and confirm that it works, that will also help me.
Thanks for contributing!

Verified, Works fine with variable width slides and great to have firstSlideLeftAligned feature.

Thanks for checking. Glad to know it will be a help.

@Saturate

Copy link
Copy Markdown
Collaborator

Looks, good. But my computer died, I'll get a new one the 21th so it's hard for me to make the final things - it's not forgotten :)

@nishantuie

nishantuie commented Nov 19, 2019 via email

Copy link
Copy Markdown
Author

@nishantuie

Copy link
Copy Markdown
Author

Looks, good. But my computer died, I'll get a new one the 21th so it's hard for me to make the final things - it's not forgotten :)

@Saturate Thanks for reviewing.

@giancarlosisasi

Copy link
Copy Markdown

👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants