some fixes - #38
Open
leonclifford wants to merge 8 commits into
Open
some fixes#38leonclifford wants to merge 8 commits into
leonclifford wants to merge 8 commits into
Conversation
lunarcloud
reviewed
Sep 17, 2026
| # Variables set in init.sh and used here | ||
| # shellcheck disable=SC2154 | ||
|
|
||
| function listfunc() { |
Owner
There was a problem hiding this comment.
This function is just an alias without any "if platform do a, else do b" logic and has no documentation comments. Doesn't belong in this library.
lunarcloud
reviewed
Sep 17, 2026
| # LGPL-2.1 license | ||
|
|
||
| # Get the directory where this script is located | ||
| # get the directories |
Owner
There was a problem hiding this comment.
This comment change doesn't make sense. Only one directory is being gathered by the following line(s) still
lunarcloud
reviewed
Sep 17, 2026
| # shellcheck source=./init.sh | ||
| source "${SCRIPT_DIALOG_DIR}/init.sh" | ||
| # sources everything in folder, excludes current file | ||
| for src in ./*.sh |
Owner
There was a problem hiding this comment.
I would prefer a finite list rather than an unbounded "all in folder" for obvious security reasons
Owner
|
Not seeing where the "call function from script" logic is but I'm not sure it's preferable to the "source script-dialog; datepicker" workflow. But the months as array lookup is a nice one. Maybe not bundling an api change and a code cleanup together would be best. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes i made:
script-dialog.sh: Sources are gathered automatically from folder to avoid source issues and added function call from command: "$ ./script-dialog datepicker" in CLI calls datepicker function.
datepicker.sh: Replaced month=number if chain by an array that contains month and it's number associated: Jan[1].