use encoding of underlying levelup - #3
Open
mvayngrib wants to merge 1 commit into
Open
Conversation
| var feed = {} | ||
| var lock = mutexify() | ||
|
|
||
| var valueEncoding = db.options.valueEncoding || 'binary' |
Owner
There was a problem hiding this comment.
lets add an options argument to module.exports and do options.valueEncoding || db.options.valueEncoding || 'binary'
Collaborator
Author
There was a problem hiding this comment.
can valueEncoding passed in to options be different from db.options.valueEncoding? Seems like that would cause problems
Owner
There was a problem hiding this comment.
yea. db.options.valueEncoding is just a default value. utf-8, json, binary, anEncoderObject is always accepted
Collaborator
Author
There was a problem hiding this comment.
right, so maybe db.options.valueEncoding || options.valueEncoding || 'binary' would be better
Contributor
There was a problem hiding this comment.
db.options.valueEncoding is always set to my knowledge (defaults to utf8) so that wouldn't work afaik
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
so you can do
this would mean for binary, you'd have to explicitly specify level('path', { valueEncoding: 'binary' })