Skip to content

continuation of #14 - #17

Merged
magiccodingman merged 20 commits into
magiccodingman:masterfrom
yueyinqiu:async2
Nov 27, 2024
Merged

continuation of #14#17
magiccodingman merged 20 commits into
magiccodingman:masterfrom
yueyinqiu:async2

Conversation

@yueyinqiu

Copy link
Copy Markdown
Collaborator

continuation of #14

@yueyinqiu

yueyinqiu commented Nov 27, 2024

Copy link
Copy Markdown
Collaborator Author

I think this PR is ready now. I have completely removed the events! Hope that everything could work correctly.

And I think there are many things need to be reconsider later. For example:

@yueyinqiu
yueyinqiu marked this pull request as ready for review November 27, 2024 06:58
@yueyinqiu yueyinqiu changed the title [WIP] continuation of #14 continuation of #14 Nov 27, 2024
@magiccodingman

Copy link
Copy Markdown
Owner

@yueyinqiu Great follow up. AOT is amazing, but I've been hesitant about it for a variety of reasons. Every time I've tested AOT thoroughly. At least from my personal experience, I get very odd production issues depending on the devices/OS/environment. Though that's from a Blazor WASM experience, so I'm unsure about as a library.

But additionally, if I remember correctly, there's system reflections in the project. I think? I feel like I did system reflections. And if my memory serves me right, AOT + reflections != good results. Reflections often if not outright fails with AOT.

But, I do think it's 100% worth investigating! Because if AOT causes no issues at all, then AOT is 100% better!

Also the code looks good to me. I may have some time to setup a proper XUnit project within the solution this weekend. That way future PR's can include unit testing. Thank you!

@magiccodingman
magiccodingman merged commit e9ddf81 into magiccodingman:master Nov 27, 2024
@yueyinqiu
yueyinqiu deleted the async2 branch November 28, 2024 10:26
@yueyinqiu
yueyinqiu restored the async2 branch December 4, 2024 06:57
@yueyinqiu
yueyinqiu deleted the async2 branch December 4, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants