continuation of #14 - #17
Conversation
|
I think this PR is ready now. I have completely removed the events! Hope that everything could work correctly. And I think there are many things need to be reconsider later. For example:
|
|
@yueyinqiu Great follow up. AOT is amazing, but I've been hesitant about it for a variety of reasons. Every time I've tested AOT thoroughly. At least from my personal experience, I get very odd production issues depending on the devices/OS/environment. Though that's from a Blazor WASM experience, so I'm unsure about as a library. But additionally, if I remember correctly, there's system reflections in the project. I think? I feel like I did system reflections. And if my memory serves me right, AOT + reflections != good results. Reflections often if not outright fails with AOT. But, I do think it's 100% worth investigating! Because if AOT causes no issues at all, then AOT is 100% better! Also the code looks good to me. I may have some time to setup a proper XUnit project within the solution this weekend. That way future PR's can include unit testing. Thank you! |
continuation of #14